Add dual qr reading - #32
Open
devferx wants to merge 1 commit into
Open
Conversation
combimauri
reviewed
Dec 16, 2023
| return docData.data() as AppQr | undefined; | ||
| } | ||
|
|
||
| readQr(qr: AppQr, user: AppUser) { |
combimauri
reviewed
Dec 16, 2023
| const balance = qr?.balance ?? 0; | ||
|
|
||
| if (qr.users?.includes(user.email!)) { | ||
| return from(Promise.reject('Ya has escaneado este código')).pipe( |
Contributor
There was a problem hiding this comment.
Ya escaneaste este código
combimauri
reviewed
Dec 16, 2023
| if (!this.isScannActive) return; | ||
|
|
||
| if (qrData.startsWith('{') && qrData.endsWith('}')) { | ||
| const data = JSON.parse(qrData); |
Contributor
There was a problem hiding this comment.
This may potentially throw an error, you should handle that
combimauri
reviewed
Dec 16, 2023
| this.dialogRef.close(); | ||
| } | ||
|
|
||
| ngOnDestroy(): void {} |
Contributor
There was a problem hiding this comment.
This is not needed, delete it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.