feat: Error reporting at the end of the simulatiuon by arng40 · Pull Request #3929 · GEOS-DEV/GEOS

arng40 · 2025-12-23T15:52:12Z

Will be merged after : #3902

Introduce a logHistory to store all the log
Gathering logs between ranks

Located after MemoryStatsOutput :

Ex :

Types	Error	ExternalError	Warning	Exception
MeshGeneration	0	0	3	0
NumericalMethods	0	0	5	0
ImportFields	0	0	5	0

…rser.h modifications since no longer useful

…sts by feature

…y/create-yaml-file-and-structure

…ttps://github.com/amandinehry/GEOS into feature/amandinehry/create-yaml-file-and-structure

…mandinehry/create-yaml-file-and-structure

…t-test + testing GEOS_ERROR

…unit test separation for multiple EXPECT_EXIT

…upported by fmt for now)

…ASSERT and GEOS_THROW are now compatible with context parameters)

…y/create-yaml-file-and-structure

src/coreComponents/common/logger/LogHistory.cpp

src/coreComponents/common/logger/LogHistory.hpp

src/coreComponents/common/format/table/TableData.hpp

MelReyCG · 2026-03-10T17:19:52Z

src/coreComponents/common/format/LogPart.cpp


  m_enableOutput = enableOutput;
+
+  ErrorLogger::global().setCurrentLogPart( std::string(logpartName) );


Storing this "current log part" information in the logger instance is the thing to do, but I don't think that is at the right moment.
I think it should be at the begin() moment, and the logger instance should be given as parameter OR the logger instance should be able to begin a given log part (and store it).
-> what do you choose?

The 2nd option is better, it's up to the logger de decide.
I'll do this update in an another PR

ok! I keep the comment open, keep it as reference in the ticket and future PR description.

…-report

src/coreComponents/common/format/LogPart.hpp

src/coreComponents/common/format/EnumStrings.hpp

src/coreComponents/common/logger/ErrorHandling.hpp

src/coreComponents/common/logger/LogHistory.cpp

src/coreComponents/common/logger/LogHistory.hpp

src/coreComponents/common/logger/LogHistory.cpp

src/coreComponents/common/logger/LogHistory.hpp

src/coreComponents/mainInterface/ProblemManager.cpp

…-report

MelReyCG

can we see a real case sample?

MelReyCG · 2026-03-12T14:52:09Z

src/coreComponents/common/logger/LogHistory.cpp

+  }
+  else
+  {
+    it->second.m_count +=  1;


Should this be?

Suggested change

it->second.m_count += 1;

it->second.m_count += logRecord.m_value.m_count;

MelReyCG · 2026-03-18T17:25:34Z

src/coreComponents/mainInterface/GeosxState.cpp


  GEOS_THROW_IF_NE( m_state, State::UNINITIALIZED, geos::LogicError );
-
+  LogPart postProcessiveLog( "Parsing", MpiWrapper::commRank() == 0 );


What do you think of

Suggested change

LogPart postProcessiveLog( "Parsing", MpiWrapper::commRank() == 0 );

LogPart postProcessiveLog( "Input Files Processing", MpiWrapper::commRank() == 0 );

MelReyCG · 2026-03-18T17:28:32Z

src/coreComponents/physicsSolvers/PhysicsSolverBase.cpp

+  if( MpiWrapper::commRank() == 1 )
+  {
+    GEOS_WARNING( "labla" );
+  }


Be careful, you tend to forget more and more of these in your recent works

MelReyCG · 2026-03-18T17:32:08Z

src/coreComponents/common/MpiWrapper.hpp

+      >
+    >
+  static GatherResult< CONTAINER >
+  gatherBufferRank0( CONTAINER const & localBuffer )


I'm not sure which PR should go first... One should be based on the other one because you implement this in the two PRs. Taking into account any comment / change on the other PR

MelReyCG · 2026-03-18T17:33:20Z

src/coreComponents/common/unitTests/testDataTypes.cpp

+#include "common/StdContainerWrappers.hpp"
+
+
+// // TPL includes
 #include <gtest/gtest.h>
 #include <gtest/gtest-spi.h>
+#include <memory>


you can revert

MelReyCG · 2026-03-18T17:38:01Z

src/coreComponents/common/logger/LogHistory.hpp

+    {
+      static_assert( std::is_trivially_copyable_v< T > );
+      if( ptr + sizeof(T)> end ) throw std::runtime_error( "Buffer truncated" );
+      memcpy( &data, ptr, sizeof(T) );
+      ptr += sizeof(T);
+    }


-> CPP
Here and for all other >1 function, as usual.

MelReyCG · 2026-03-18T17:41:17Z

src/coreComponents/common/logger/LogHistory.cpp

+  TableLayout tableLayout;
+  tableLayout.addColumn( "Types" );
+
+  // fill header


you can maybe add some more "part" comments for this function I think.

MelReyCG · 2026-03-18T17:42:52Z

src/coreComponents/common/logger/LogHistory.cpp

+  tableLayout.addColumn( "Types" );
+
+  // fill header
+  for( size_t msgTypeIdx = (size_t) MsgType::Error; msgTypeIdx != (size_t)MsgType::Undefined; msgTypeIdx++ )


Do as I did in my PR for the -d:

Suggested change

for( size_t msgTypeIdx = (size_t) MsgType::Error; msgTypeIdx != (size_t)MsgType::Undefined; msgTypeIdx++ )

for( size_t msgTypeIdx = 0; msgTypeIdx < (size_t)MsgType::Count; msgTypeIdx++ )

MelReyCG and others added 30 commits July 23, 2025 17:24

🐛 ⏪ set the --errorsOutput mandatory because of bug + revert optionpa…

35f7686

…rser.h modifications since no longer useful

✏️ typo

31842a5

🎨 uncrustify

a1105e4

🎨 docs alignement

c118dd4

🎨 format

4215fad

builder pattern for addContextInfo

507ac66

♻️ refactor of the test: keeping only necessary testing, separated te…

7b4ec52

…sts by feature

🐛 bugfix for test, wrong global instance impacting

a01d8ac

🎨 format

d4c465b

Merge remote-tracking branch 'origin/develop' into feature/amandinehr…

1e32d65

…y/create-yaml-file-and-structure

⏪ restored "Rank N:" if error messages

6d10e3a

test

e9cd64c

Merge branch 'feature/amandinehry/create-yaml-file-and-structure' of h…

c7031bf

…ttps://github.com/amandinehry/GEOS into feature/amandinehry/create-yaml-file-and-structure

uncomment the rmoveFile() function

e07d0b7

stack trace management

785636b

Merge remote-tracking branch 'amandinehryFork/develop' into feature/a…

dd3b844

…mandinehry/create-yaml-file-and-structure

♻️ ✅ New GEOS_ERROR macros with context included + new unit macro uni…

e0bad67

…t-test + testing GEOS_ERROR

✅ ♻️ Simplifying + testing macros (GEOS_ERROR_* and GEOS_ASSERT_*) + …

ab40edc

…unit test separation for multiple EXPECT_EXIT

📝 adding macro docs

faa84fa

✨ ✅ adding error cause in unit test

dd97f0e

♻️ reordered error & throw macro to group them

d708cac

♻️ ✅ uniformized warning macros

66ab5cb

✅ 🐛 ⚡️ bugfix when callstack is empty + disable callstack for perfs

e6135b1

♻️ ✅ uniformized throw macros

589fcfe

✅ removing _CTX macros from unit test

6fc4b30

🐛 use streamed cause string to support mpi pointers formatting (not s…

77f9fcb

…upported by fmt for now)

🐛 last mistake?

5747e7f

♻️ removing all GEOS_*_CTX macros (as GEOS_ERROR, GEOS_WARNING, GEOS_…

10eb969

…ASSERT and GEOS_THROW are now compatible with context parameters)

🎨 UNCRUSTIFY

2c5c5f5

Merge remote-tracking branch 'origin/develop' into feature/amandinehr…

d1642e6

…y/create-yaml-file-and-structure

arng40 added 11 commits March 4, 2026 10:06

remove circular dep

fe76e62

comment file

98762f0

make add row template

440beca

remove pack functions

0481762

wip create a logRecord

aad10c4

some renaming and logical update

f9d2501

address comment

edcf4f8

improve readability

f966ebb

fix desrialization

9f31612

doxygen + some renaming

d458668

fix reinterpret_cast

171b278

MelReyCG requested changes Mar 10, 2026

View reviewed changes

arng40 added 4 commits March 11, 2026 11:50

log record private & removed log part from argument

c6177ab

set logPart to diagnosticMsg

115a23e

Merge remote-tracking branch 'origin/develop' into feat/dudes/warning…

7c89805

…-report

update addRow<CellData>

72c0bc7

MelReyCG requested changes Mar 12, 2026

View reviewed changes

arng40 added 7 commits March 12, 2026 15:00

adress review ( doc + logic )

1027ff2

add operator and missing doc

183e0fe

doc

de4c9e7

add gatherBuffer to MPIWrapper

6a010ae

Merge remote-tracking branch 'origin/develop' into feat/dudes/warning…

db2ac84

…-report

Merge remote-tracking branch 'origin/develop' into feat/dudes/warning…

556b5e5

…-report

⏪ default allocator stdWrapper

ccdcad5

arng40 mentioned this pull request Mar 17, 2026

refactor: Move LogPart assignment #3998

Draft

arng40 added 4 commits March 17, 2026 14:31

⏪ revert logger

ca1c677

➕ add logger to scotch

16a662b

💚 doxygen & uncrustify

bf74177

💚 uncrustify

94f4209

MelReyCG requested changes Mar 18, 2026

View reviewed changes


		m_enableOutput = enableOutput;

		ErrorLogger::global().setCurrentLogPart( std::string(logpartName) );

	it->second.m_count += 1;
	it->second.m_count += logRecord.m_value.m_count;


		GEOS_THROW_IF_NE( m_state, State::UNINITIALIZED, geos::LogicError );

		LogPart postProcessiveLog( "Parsing", MpiWrapper::commRank() == 0 );

	LogPart postProcessiveLog( "Parsing", MpiWrapper::commRank() == 0 );
	LogPart postProcessiveLog( "Input Files Processing", MpiWrapper::commRank() == 0 );

	for( size_t msgTypeIdx = (size_t) MsgType::Error; msgTypeIdx != (size_t)MsgType::Undefined; msgTypeIdx++ )
	for( size_t msgTypeIdx = 0; msgTypeIdx < (size_t)MsgType::Count; msgTypeIdx++ )

Conversation

arng40 commented Dec 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

arng40 Mar 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

MelReyCG left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

arng40 commented Dec 23, 2025 •

edited

Loading

arng40 Mar 11, 2026 •

edited

Loading