Skip to content

feat: inner products for mixed method#3994

Open
chauj96 wants to merge 9 commits intodevelopfrom
feature/inner_products_for_mixed_method
Open

feat: inner products for mixed method#3994
chauj96 wants to merge 9 commits intodevelopfrom
feature/inner_products_for_mixed_method

Conversation

@chauj96
Copy link
Contributor

@chauj96 chauj96 commented Mar 12, 2026

This PR adds the implementation of computeM, which computes the inner product matrix $M$ used in the MFD mixed method formulation.

  1. The function has been implemented for the following inner product types:
  • TPFAInnerProduct
  • BdVLMInnerProduct
  • QuasiTPFAInnerProduct
  • SimpleInnerProduct
    Each class now includes a computeM routine that construct the inner product matrix $M$ required for the mixed formulation.
  1. Testing
    Unit tests were added in testMimeticInnerProducts to verify the correctness of the newly implemented computeM functions. All tests currently pass.

+) Minor variable naming updates were applied in SimpleInnerProduct to keep the geometry nomenclature consistent with the other inner product implemenations.

@chauj96 chauj96 changed the title Feature/inner products for mixed method feat:inner products for mixed method Mar 12, 2026
@chauj96 chauj96 self-assigned this Mar 12, 2026
@chauj96 chauj96 added ci: run CUDA builds Allows to triggers (costly) CUDA jobs ci: run integrated tests Allows to run the integrated tests in GEOS CI ci: run code coverage enables running of the code coverage CI jobs flag: no rebaseline Does not require rebaseline labels Mar 12, 2026
@chauj96 chauj96 changed the title feat:inner products for mixed method feat: inner products for mixed method Mar 16, 2026
@chauj96 chauj96 marked this pull request as ready for review March 16, 2026 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci: run code coverage enables running of the code coverage CI jobs ci: run CUDA builds Allows to triggers (costly) CUDA jobs ci: run integrated tests Allows to run the integrated tests in GEOS CI flag: no rebaseline Does not require rebaseline

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants