feat: Prevent ghost elements from modifying their own data in contact solvers#4000
Open
feat: Prevent ghost elements from modifying their own data in contact solvers#4000
Conversation
bd713
requested review from
castelletto1,
jhuang2601 and
rrsettgast
as code owners
Member
|
@bd713 were these getting update with incorrect values? I ask because ghost elements are allowed to update their stress state since it derives from the displacement field which is synchronized? |
Contributor
Author
|
@rrsettgast No. It's more about having consistent ghost handling across the solver, than fixing a known bug. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP
Objective
Prevent ghost elements from modifying their own data in contact solvers
Instead, only receive updates via proper synchronization.