fix: Infinite hang when MPI process crashes#4001
Draft
Conversation
arng40
added
type: bug
arng40
changed the title
MelReyCG
approved these changes
Mar 18, 2026
jhuang2601
added
ci: run CUDA builds
Member
|
The second call to to avoid cleanup issues. Are you sure this doesn't reintroduce the issues that it fixed? |
MelReyCG
requested changes
Mar 19, 2026
Contributor
MelReyCG
left a comment
MelReyCG
left a comment
There was a problem hiding this comment.
Ok, so let's change the strategy:
- separate anything that is not about cleaning up from
basicCleanup()to a new function (finalizeRun()? something else?), - call
basicCleanup()in anfinallyclause, to ensure it is called, but any logging of a potencial error must be done before.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bug occurs when you launch a simulation with multiple ranks and one of the ranks calls a GEOS_THROW. This results in an infinite hang