Add river routing module for offline (GEOSldas) simulations#1143
Add river routing module for offline (GEOSldas) simulations#1143
Conversation
…t in GEOSgcm_GridComp/GEOSagcm_GridComp/GEOSphysics_GridComp/GEOSsurface_GridComp/GEOSland_GridComp/GEOSroute_GridComp
…ent (GEOS_RouteGridComp.F90)
|
@gmao-rreichle @weiyuan-jiang I have modified the routing model code to make it read the *.nc4 tile files. |
gmao-rreichle
left a comment
There was a problem hiding this comment.
@zyj8881357 , @weiyuan-jiang : Sorry it took me so long to pick up the routing PR again. I have a few more cleanup questions, see below.
Merging the PR has gained some urgency because the SI team is planning to make relatively invasive changes across all GridComp F90 files under Surface. These changes will result in lots of conflicts with the present PR. Ideally, we can merge the present PR before the SI team makes their changes.
…ency with module name and to avoid generic file name
…lict and for consistency with F90 file names (./Raster/preproc/outlets/*.f90, ./Raster/preproc/routing_model/*.f90)
… file name was change in previous commit)
gmao-rreichle
left a comment
There was a problem hiding this comment.
@zyj8881357 :
Thanks for making the changes. I went through and resolved conversations when possible. I further cleaned up the module names for the outlets and routing constants. Note that there was a naming conflict after your most recent change, when both modules were named "routing_constant".
Here's a list of open issues:
- Please try simulations for (i) a non-global domain on the EASE grid and (ii) a domain that includes landice tiles. Weiyuan isn't sure that the new *-Pfafstetter tile file for EASE works with non-global domains (#1143 (comment)), and I'm not sure if we ever tested a simulation with landice tiles.
- Biljana mentioned you gave her a new routing_parameter.nc file. Are the new parameters based on SMAP NRv11.4? (#1143 (comment))
- The program
get_num_sub_catchment.f90doesn't seem to use the info from the *-Pfafstetter tile file. Instead, it looks to me like it compute things from scratch based on raster information. What exactly do we need this program to do, and can it be done more cleanly using the *-Pfafstetter tile file?
cc: @weiyuan-jiang
|
During testing besides this branch/PR I used:
|
…n_yujin (manually resolved conflict in make_bcs_shared.py)
9d1a15f
Add river routing module for offline land modeling (GEOSldas). Replaces #1023
Successfully 0-diff tested by @biljanaorescanin on 10-Apr-2026 #1143 (comment)
Merged branch of #1149 into present PR to resolve anticipated conflict when merging present PR after #1149 (9d1a15f)
Left for future PRs:
Related PRs:
Testing:
List of tasks that remain to be addressed (in no particular order):
@YujiN, I am trying to bring back some codes in develop branch. The develop branch is not working as it is but I believe it would be more efficient. The runoff and the other variables are distributed as needed, which is way more efficient than allgatherV.