introduce NAS platforms, take da-utils out, again#101
Closed
Dooruk wants to merge 27 commits into
Closed
Conversation
* Implement matrix strategy for coding norms * same for clone * fix syntax
There was a problem hiding this comment.
Pull request overview
This PR introduces support for two new NASA NAS platforms (aitken and pleiades) and removes the da-utils bundle due to incompatibility with iodaconv. Additionally, it enhances CI workflows to test against Python 3.10 and 3.11, updates GitHub Actions versions, and adjusts build configuration settings.
Key Changes:
- Added platform configurations for
nas_aitkenandnas_pleiadeswith multiple compiler variants (intel-oneapi, gnu, and GEOS-specific variants) - Removed
da-utilsbundle and its pinned version entry - Reordered GitHub organizations in build configuration, prioritizing JCSDA over JCSDA-internal and removing NOAA-EMC
- Increased parallel build cores from 6 to 24 for improved build performance
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
src/jedi_bundle/config/platforms/nas_pleiades.yaml |
New platform configuration for NASA NAS Pleiades system with hostname detection for 'pfe' |
src/jedi_bundle/config/platforms/nas_aitken.yaml |
New platform configuration for NASA NAS Aitken system with hostname detection for 'afe' |
src/jedi_bundle/config/pinned_versions.yaml |
Removed pinned version entry for da-utils package |
src/jedi_bundle/config/bundles/da-utils.yaml |
Deleted bundle configuration file for da-utils |
src/jedi_bundle/config/build.yaml |
Reordered GitHub organizations, removed NOAA-EMC, increased build parallelism to 24 cores |
src/jedi_bundle/__init__.py |
Version bump from 1.0.30 to 1.0.40 |
.github/workflows/python_coding_norms.yml |
Added Python 3.10 and 3.11 matrix testing, improved indentation consistency |
.github/workflows/clone_a_jedi_bundle.yml |
Added Python version matrix, updated actions to v5, removed --user flag from pip install, added PR fork check |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduces
aitkenandpleiades(this one will get decommisioned soon).Takesunfortunately we couldn't figure this outJCSDAout from defaultbuild.yaml.da-utilscan't be installed withiodaconv, so for now let's take it out.