Skip to content

fix: gui CI after closure lifetime merge#3

Open
GGRei wants to merge 1 commit into
mainfrom
fix/ci-after-closure-lifetime-merge
Open

fix: gui CI after closure lifetime merge#3
GGRei wants to merge 1 commit into
mainfrom
fix/ci-after-closure-lifetime-merge

Conversation

@GGRei

@GGRei GGRei commented Jun 19, 2026

Copy link
Copy Markdown
Owner

Summary

This updates the v-gui CI after the closure lifetime/reclaim work landed in V.

The Windows job was still pinned to V 0.5.1, which does not include the new closure lifetime/reclaim API used by v-gui. This switches the Windows job to vlang/setup-v with the latest V compiler, matching the other CI jobs more closely.

It also refreshes the Windows dependency cache keys from the installed V version, so compiler updates do not keep reusing stale V/vglyph-related caches.

Changes

  • Use vlang/setup-v@v1.4 for the Windows CI job.
  • Log the installed V version instead of checking against a pinned old release.
  • Key Windows vcpkg and vglyph caches from the installed V version.
  • Format examples/showcase.v so the CI format check passes.

Notes

This PR does not change the closure lifetime/reclaim behavior itself.

macOS still depends on the separate vglyph fix, because the current failure there comes from compiling vglyph as a dependency with newer V checks.

Tests

v fmt -verify examples/showcase.v
git diff --check

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 70251d7613

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread .github/workflows/ci.yml Outdated
@GGRei GGRei force-pushed the fix/ci-after-closure-lifetime-merge branch from 70251d7 to 17af549 Compare June 19, 2026 14:19
@GGRei

GGRei commented Jun 19, 2026

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Breezy!

Reviewed commit: 17af549151

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@GGRei GGRei force-pushed the fix/ci-after-closure-lifetime-merge branch 4 times, most recently from ad45ece to fa702d2 Compare June 19, 2026 16:17
@GGRei GGRei force-pushed the fix/ci-after-closure-lifetime-merge branch from fa702d2 to 47bed52 Compare June 19, 2026 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant