test: SDL parity gate as a CI test (close remaining codecov gap)#100
Merged
Conversation
tools/schema_parity.py (the Graphene→Strawberry SDL byte-parity gate) ran as a standalone script, so it sat at 0% coverage and dragged the migration's codecov patch/project just under the auto threshold on promote PR #97. Wrap it in tests/test_sdl_parity.py — happy path (diff()=='' , main()==0) and a drift case (different baseline → non-empty diff, main()==1). Bonus: the SDL parity gate is now a permanent CI test, not a manual invocation. schema_parity.py 0% → 100%; package coverage 96% → 98%.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## deploy-test #100 +/- ##
===============================================
+ Coverage 95.08% 96.54% +1.45%
===============================================
Files 12 12
Lines 1099 1099
Branches 63 63
===============================================
+ Hits 1045 1061 +16
+ Misses 41 25 -16
Partials 13 13
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #99. Migration codecov on #97 was still a hair under the auto threshold (patch 95.51% vs 95.73%) because
tools/schema_parity.py— the SDL byte-parity gate — ran as a standalone script at 0% coverage.Wrap it as
tests/test_sdl_parity.py(happy path + drift detection).schema_parity.py0%→100%, package coverage 96%→98%. Side benefit: the SDL parity gate is now a permanent CI test, not a manual step.