Fix magnet filter only checking first configured slot#410
Merged
UltraProdigy merged 1 commit intoGTNewHorizons:masterfrom Mar 7, 2026
Merged
Conversation
The isItemFiltered method returned the comparison result on the first non-null filter slot, exiting the loop even on non-match. Items in slots beyond the first were never checked. Store the comparison in a local variable and only return true on match, allowing the loop to continue to subsequent filter slots. Fixes GTNewHorizons/GT-New-Horizons-Modpack#23776 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
lc-1337
approved these changes
Mar 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
The magnet filter's
isItemFilteredmethod only respected the first configured slot. Items configured in slots 2-27 were ignored.Root cause: Each comparison branch inside the for loop used
return <condition>instead of storing the result. When the first non-null slot didn't match, the method returnedfalseimmediately, never checking subsequent slots.Reproduction: Configure the magnet filter whitelist with two different items (e.g. eggs in slot 0, feathers in slot 1). Only the item in slot 0 gets filtered; the item in slot 1 is ignored.
Fix
Store each comparison result in a local variable and only
return trueon match, allowing the loop to continue to subsequent slots on non-match.Fixes GTNewHorizons/GT-New-Horizons-Modpack#23776
Fixes GTNewHorizons/GT-New-Horizons-Modpack#23654