Excaliber And Flugel eye.

[thenextelement]

[Unrelated botania change] Updated the link for witchery wiki to This

The Holy sword Excaliber is working again and will drop from a normal Dice roll.

Flugel Teleportation works with all 12 locations as it did in Botania 1.7.10-208 and earlier, ̶b̶u̶t̶ ̶s̶t̶i̶l̶l̶ ̶n̶e̶e̶d̶ ̶t̶o̶ ̶f̶i̶g̶u̶r̶e̶ ̶o̶u̶t̶ ̶h̶o̶w̶ ̶t̶o̶ ̶g̶e̶t̶ ̶t̶h̶e̶ ̶D̶i̶s̶t̶a̶n̶c̶e̶ ̶f̶r̶o̶m̶ ̶w̶a̶r̶p̶ ̶l̶o̶c̶a̶t̶i̶o̶n̶s̶/̶n̶a̶m̶e̶s̶ ̶o̶f̶ ̶t̶h̶e̶ ̶w̶a̶r̶p̶ ̶l̶o̶c̶a̶t̶i̶o̶n̶s̶ ̶f̶u̶n̶c̶t̶i̶o̶n̶a̶l̶ ̶a̶g̶a̶i̶n̶.̶ ~ Fixed :D

I was only going to PR the wiki update, but have been working on this for my own pack and was requested to PR by Brandyn.

https://github.com/VazkiiMods/Botania/blob/67ae60a5f591c39fe1df81eebec0c094c639671f/src/main/java/vazkii/botania/common/item/relic/ItemFlugelEye.java

Linked is the eye of the flugel code as it was in build 208 of Botania.

[thenextelement]

This also includes re-arranged Achievements to accommodate the Excaliber

[Nikolay-Sitnikov]

How do you get seven items from six-sided Dice of Fate?

[thenextelement]

How do you get seven items from six-sided Dice of Fate?

By changing the range for dice drops from 0-5 to 0-6 💀
Also I believe I have figured out the eye of the flugel, testing in a minute.

[thenextelement]

Done :D

[thenextelement]

Dice pool doesn't seem to actually be working 💀

[thenextelement]

Dice pool is for sure working now, will push update.

[Shahelion]

Important to note that the Alfheim mod does the same thing, causing an incompatibility when loaded together.

[Dream-Master]

@Shahelion @thenextelement maybe when Botania is integrated better we can think of add Alfheim also

[Shahelion]

Turns out the main conflict comes from Alfheim overwriting the ItemDice code to give random loot instead of nothing when it lands on a number that's already been hit. The Flugel Eye and Excalibur are implemented as separate items, so that part's fine.

There are quite a few users who are using both Alfheim and the GTNH fork of Botania, based on what I've seen so far, especially since Botania is in the Active Support category. Maybe just a config to disable this, or auto-disable if Alfheim is present?

[thenextelement]

Assuming Alfheim doesn't get added, the only thing this PR needs is a localization issue in the controls settings for Loki ring, iirc the mirror keybind is unlocalized.
Havent gotten back into my fork in a minute, assuming Alfheim does get added though this can safely be closed as I really only changed the two things.
For my own fork at least I think the only other thing I plan to change is the default setting for Passive flower decay which I would prefer to be off by default, but I assume that wouldn't fly in this pack.
I will say I don't think Alfheim would fit the pack particularly well, though it does have some interesting things I feel it would lead to some thematic clash.
I do like the idea of the Alfheim dimension though, always disappointed me that Botania didn't have any Dimensions.

[thenextelement]

Also If Alfheim doesn't get added I will say I'm not quite talented enough to put in a check for disabling of these changes when Alfheim is present in runtime, nor setting up any configs, I know a little bit about annotated config code but have only observed it and haven't implemented it myself before.
I do apologize as is this PR is a bitch of a hatchet job, I initially was only going to keep a personal fork but was asked to open a PR here, I do hope it can get approved in some form but I did literally just rip the old code and assets from build 208 of Botania for these 2 changes and edited the english lang file/relevant class files where I could find discrepancies, the most custom thing done here was re arranging the Relic achievements.
While it has proven stable for use in my custom pack I also haven't pushed it very hard.