Skip to content

Fix buttons not rendering for 1 tick when changing inv tabs #292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Lyfts merged 2 commits into from
May 14, 2026
Merged

Fix buttons not rendering for 1 tick when changing inv tabs #292

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9c66efe
fix buttons not rendering for 1 tick when changing inv tabs
Lyfts May 14, 2026
c1ec7c7
update deps
Lyfts May 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions dependencies.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,19 +2,19 @@

dependencies {

api("com.github.GTNewHorizons:GTNHLib:0.9.62:dev")
compileOnly("com.github.GTNewHorizons:NotEnoughItems:2.8.96-GTNH:dev") {transitive = false}
api("com.github.GTNewHorizons:GTNHLib:0.9.66:dev")
compileOnly("com.github.GTNewHorizons:NotEnoughItems:2.8.98-GTNH:dev") {transitive = false}
compileOnly("com.github.GTNewHorizons:EnderIO:5.2.62:dev") {transitive = false}
compileOnly("com.github.GTNewHorizons:Random-Things:2.7.5:dev") {transitive = false}
compileOnly("com.github.GTNewHorizons:Navigator:1.1.2:dev")
compileOnly("com.github.GTNewHorizons:Random-Things:2.7.7:dev") {transitive = false}
compileOnly("com.github.GTNewHorizons:Navigator:1.1.3:dev")
compileOnly('org.jetbrains:annotations:25.0.0')
compileOnly('com.github.GTNewHorizons:Baubles-Expanded:2.2.14-GTNH:dev') {transitive = false}
compileOnly('com.github.GTNewHorizons:Baubles-Expanded:2.2.17-GTNH:dev') {transitive = false}
compileOnly('com.github.GTNewHorizons:Battlegear2:1.4.3:dev') {transitive = false}
compileOnly('com.github.GTNewHorizons:Galacticraft:3.4.27-GTNH:dev') {transitive = false}
compileOnly('com.github.GTNewHorizons:TinkersConstruct:1.14.64-GTNH:dev') {transitive = false}
compileOnly('com.github.GTNewHorizons:Galacticraft:3.4.28-GTNH:dev') {transitive = false}
compileOnly('com.github.GTNewHorizons:TinkersConstruct:1.14.70-GTNH:dev') {transitive = false}
compileOnly('com.github.GTNewHorizons:AdventureBackpack2:1.4.19-GTNH:dev') {transitive = false}
compileOnly('com.github.GTNewHorizons:Minecraft-Backpack-Mod:2.6.12-GTNH:dev') {transitive = false}
compileOnly(rfg.deobf("curse.maven:witchery-69673:2234410")) {transitive = false}

runtimeOnlyNonPublishable("com.github.GTNewHorizons:waila:1.19.25:dev")
runtimeOnlyNonPublishable("com.github.GTNewHorizons:waila:1.19.28:dev")
}
6 changes: 1 addition & 5 deletions src/main/java/serverutils/client/gui/GuiSidebar.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
package serverutils.client.gui;

import java.awt.Rectangle;
import java.util.ArrayList;
import java.util.List;

Expand Down Expand Up @@ -32,7 +31,6 @@
public class GuiSidebar extends GuiButton {

private static final List<String> sidebarButtonTooltip = new ArrayList<>();
public static Rectangle lastDrawnArea = new Rectangle();
public static int dragOffsetX = 0, dragOffsetY = 0;
private final GuiContainer gui;
public final List<GuiButtonSidebar> buttons;
Expand All @@ -57,11 +55,11 @@ public void drawButton(Minecraft mc, int mx, int my) {
clearButtons();
}

this.setButtonLocations(mc, mx, my);
if (buttons.isEmpty()) {
addButtonsToSidebar();
}

setButtonLocations(mc, mx, my);
int x = Integer.MAX_VALUE;
int y = Integer.MAX_VALUE;
int maxX = Integer.MIN_VALUE;
Expand Down Expand Up @@ -126,8 +124,6 @@ public void drawButton(Minecraft mc, int mx, int my) {
GlStateManager.disableDepth();
GlStateManager.popMatrix();
zLevel = 0F;

lastDrawnArea = new Rectangle(xPosition, yPosition, width, height);
}

public void addTooltip(List<String> textLines) {
Expand Down
Loading