Add timeouts to all remote fetches in RemoteHandler - #25
Draft
PLASMAchicken wants to merge 1 commit into
Draft
Conversation
The three JSON fetches (version manifest, version details, asset index) used IOUtils.toString(URL), which opens the connection without connect/read timeouts. On networks that silently drop packets (captive portals, filtering proxies), the TLS handshake to launchermeta.mojang.com blocks forever, freezing the game during coremod injection (RemoteHandler.getVersions is called unconditionally from TXLoaderCore.injectData). All remote connections now go through a shared openStream helper with uniform timeouts (5s connect / 10s read), replacing the duplicated timeout setup in downloadJar and JAsset.download. On timeout, getVersions() fails fast and the game launches normally with isRemoteReachable = false.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The three JSON fetches (version manifest, version details, asset index) used IOUtils.toString(URL), which opens the connection without connect/read timeouts. On networks that silently drop packets (captive portals, filtering proxies), the TLS handshake to launchermeta.mojang.com blocks forever, freezing the game during coremod injection (RemoteHandler.getVersions is called unconditionally from TXLoaderCore.injectData).
All remote connections now go through a shared openStream helper with uniform timeouts (5s connect / 10s read), replacing the duplicated timeout setup in downloadJar and JAsset.download. On timeout, getVersions() fails fast and the game launches normally with isRemoteReachable = false.
Fixes https://canary.discord.com/channels/181078474394566657/1466025211840172112/1522342366764208229
Threaddump threaddump.txt
UsersFix:
Checklist