Refactor: 검색 기능 개선

[Jjiggu]

작업 요약

• 학과명 및 주점 이름으로 검색 가능하도록 쿼리 수정
• 풀텍스트인덱스 적용으로 인한 공백 붙여서 검색 가능

Issue Link

#145

문제점 및 어려움

• "컴공" 검색 시 "컴퓨터공학과" 검색 불가

해결 방안

• 추후 매핑 테이블 제작 or 엘라스틱서치 도입

Reference

Summary by CodeRabbit

• 신규 기능

  • 매장 검색 시 키워드 기반의 전체 텍스트 검색 기능이 추가되었습니다.

• 버그 수정

  • 관리자 회원가입 시 닉네임에 숫자 입력이 허용되며, 안내 메시지가 개선되었습니다.

• 기타

  • 검색 파라미터명이 'name'에서 'keyword'로 변경되었습니다.
  • 내부 검색 로직 및 저장소 구조가 개선되었습니다.

[coderabbitai]

Caution

Review failed

An error occurred during the review process. Please try again later.

"""

Walkthrough

닉네임 유효성 검사 정규식이 숫자를 허용하도록 변경되었으며, 사용자 가게 검색 API의 파라미터가 "name"에서 "keyword"로 변경되고, 검색 로직이 이름 기반에서 키워드 기반의 MySQL 전문 검색(native query)으로 대체되었습니다. StoreRepository에 커스텀 리포지토리와 관련 구현이 추가되었습니다.

Changes

파일/경로 요약	변경 내용 요약
nowait-app-admin-api/.../ManagerSignupRequestDto.java	닉네임 정규식에 숫자 허용, 커스텀 검증 메시지 추가
nowait-app-user-api/.../StoreController.java nowait-app-user-api/.../StoreService.java nowait-app-user-api/.../StoreServiceImpl.java	가게 검색 파라미터 "name" → "keyword"로 변경, 서비스/컨트롤러/구현체 메서드명 및 파라미터 일치, 검색 로직을 native query 기반으로 변경
nowait-domain/domain-core-rdb/build.gradle	QueryDsl 관련 주석(TODO) 제거
nowait-domain/domain-core-rdb/src/main/java/com/nowait/domaincorerdb/config/QueryDslConfig.java	패키지 선언 오타 수정
nowait-domain/domain-core-rdb/.../store/repository/StoreCustomRepository.java nowait-domain/domain-core-rdb/.../store/repository/StoreCustomRepositoryImpl.java	StoreCustomRepository 인터페이스 및 구현체 신규 추가(메서드 미정의, 기본 구조만 생성)
nowait-domain/domain-core-rdb/.../store/repository/StoreRepository.java	JpaRepository에 StoreCustomRepository 상속 추가, 기존 이름 검색 메서드 제거, MySQL MATCH AGAINST 기반 native 검색 메서드 추가

Sequence Diagram(s)

sequenceDiagram
    participant Client
    participant StoreController
    participant StoreService
    participant StoreRepository

    Client->>StoreController: GET /stores?keyword=xxx
    StoreController->>StoreService: searchByKeywordNative(keyword)
    StoreService->>StoreRepository: searchByKeywordNative(keyword)
    StoreRepository-->>StoreService: List<Store>
    StoreService-->>StoreController: List<StorePageReadDto>
    StoreController-->>Client: ResponseEntity

Loading

Estimated code review effort

3 (~40분)
"""

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.