Refactor: isWaiting 필드 추가

[Jjiggu]

작업 요약

사용자의 대기 상태 확인을 위한 isWaiting 필드 추가

Issue Link

#154

문제점 및 어려움

해결 방안

Reference

Summary by CodeRabbit

• 신규 기능

  • 매장 상세 정보 응답에 사용자의 웨이팅 여부(userWaiting) 및 상세 정보(공지사항, 운영 시간 등)가 추가되었습니다.

• 개선 사항

  • 매장 상세 조회 시 반환 데이터가 확장되어, 매장 이미지, 부서명, 웨이팅 인원, 북마크 여부, 공지사항, 운영 시간 등 다양한 정보를 확인할 수 있습니다.

• 버그 수정

  • 웨이팅 인원 조회 방식이 간소화되어 안정성이 향상되었습니다.

[coderabbitai]

Caution

Review failed

The pull request is closed.

"""

Walkthrough

이번 변경은 매장 상세 정보를 반환하는 API 응답 구조를 개선하고, 사용자의 대기 여부를 Redis에서 확인하는 기능을 추가합니다. 주요 변경점은 새로운 DTO 도입, 서비스 계층의 반환 타입 변경, 대기 여부 확인 메서드 추가, 그리고 관련된 데이터 변환 로직의 확장입니다.

Changes

파일/경로 요약	변경 내용 요약
.../reservation/repository/WaitingUserRedisRepository.java	코드 포맷 개선, null 체크 가독성 향상, 사용자가 대기 중인지 확인하는 isUserWaiting(Long, String) 메서드 추가
.../store/dto/StoreDetailReadResponse.java	매장 상세 정보를 담는 새로운 DTO 클래스 추가, 정적 팩토리 메서드 2종(fromEntity, fromEntityWithBookmark) 구현
.../store/dto/StorePageReadDto.java	필드 notice, openTime 추가 및 정적 팩토리 메서드에서 해당 값 설정
.../store/service/StoreService.java	getStoreByStoreId 메서드 반환 타입을 StorePageReadDto → StoreDetailReadResponse로 변경
.../store/service/StoreServiceImpl.java	getStoreByStoreId 반환 타입 변경, Redis 대기자 수 조회 로직 단순화, 사용자 대기 여부 확인 및 DTO에 반영, 의존성 주입 추가

Sequence Diagram(s)

sequenceDiagram
    participant Controller
    participant StoreServiceImpl
    participant WaitingUserRedisRepository
    participant RedisTemplate

    Controller->>StoreServiceImpl: getStoreByStoreId(storeId, user)
    StoreServiceImpl->>WaitingUserRedisRepository: isUserWaiting(storeId, userId)
    WaitingUserRedisRepository->>RedisTemplate: opsForZSet().rank(key, userId)
    WaitingUserRedisRepository-->>StoreServiceImpl: Boolean (isWaiting)
    StoreServiceImpl->>RedisTemplate: opsForZSet().zCard(key)
    StoreServiceImpl-->>Controller: StoreDetailReadResponse (with isWaiting, waitingCount, etc.)

Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~15–20 minutes
"""

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 909b265 and f299051.

📒 Files selected for processing (5)

• nowait-app-user-api/src/main/java/com/nowait/applicationuser/reservation/repository/WaitingUserRedisRepository.java (4 hunks)
• nowait-app-user-api/src/main/java/com/nowait/applicationuser/store/dto/StoreDetailReadResponse.java (1 hunks)
• nowait-app-user-api/src/main/java/com/nowait/applicationuser/store/dto/StorePageReadDto.java (3 hunks)
• nowait-app-user-api/src/main/java/com/nowait/applicationuser/store/service/StoreService.java (2 hunks)
• nowait-app-user-api/src/main/java/com/nowait/applicationuser/store/service/StoreServiceImpl.java (4 hunks)

✨ Finishing Touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch refactor/#154-add-store-notify-field

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai generate unit tests to generate unit tests for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.