refactor(Bookmark): 주점 전체 조회 isBookmark 필드 추가#180
Merged
Conversation
|
Caution Review failedThe pull request is closed. Walkthrough이 변경 사항은 북마크 및 매장 관련 DTO와 서비스 레이어의 메서드 시그니처를 전반적으로 정비합니다. Bookmark, Store, DTO, 컨트롤러, 서비스 인터페이스 및 구현체에 걸쳐 DTO 명칭 및 필드, 메서드 파라미터, 반환 타입 수정, 북마크 여부(Boolean) 추가, User 컨텍스트 반영, 관련 리포지토리 메서드 추가가 이루어졌습니다. Changes
Sequence Diagram(s)sequenceDiagram
participant Controller as StoreController
participant Service as StoreServiceImpl
participant Repo as BookmarkRepository
participant User as CustomOAuth2User
Controller->>Service: getAllStoresByPageAndDeparments(pageable, customOAuth2User)
Service->>User: getUser()
Service->>Repo: findStoreIdByUser(user)
Repo-->>Service: List<Bookmark>
Service->>Service: 북마크 Map 생성
Service->>Service: Store 리스트 → StorePageReadResponse 매핑 (isBookmark 포함)
Service-->>Controller: StoreDepartmentReadResponse
Estimated code review effort🎯 4 (Complex) | ⏱️ ~40 minutes Possibly related PRs
Note ⚡️ Unit Test Generation is now available in beta!Learn more here, or try it out under "Finishing Touches" below. 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (8)
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
작업 요약
주점 전체 조회 isBookmark 필드 추가
Issue Link
#178
문제점 및 어려움
해결 방안
Reference
Summary by CodeRabbit
신규 기능
버그 수정
리팩터