refactor(Store): 학과 이름 축제

[Jjiggu]

작업 요약

• 학과 이름 필드 추가

Issue Link

#174

문제점 및 어려움

해결 방안

Reference

Summary by CodeRabbit

• 신규 기능

  • 매장 상세 정보를 제공하는 새로운 응답 형식이 도입되어, 프로필 이미지와 배너 이미지, 부서명 등 다양한 매장 정보를 한 번에 확인할 수 있습니다.

• 기능 개선

  • 매장 상세 조회 시 반환되는 데이터가 더욱 풍부해져, 부서명과 이미지 정보가 포함된 상세 정보를 확인할 수 있습니다.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

Store 정보를 상세하게 반환하는 새로운 DTO(StoreDetailReadResponse)가 추가되었습니다. 이에 따라 서비스 계층(StoreService, StoreServiceImpl)의 getStoreByStoreId 메서드 반환 타입이 해당 DTO로 변경되고, 부서명 조회 및 포함 로직이 추가되었습니다.

Changes

Cohort / File(s)	Change Summary
Store 상세 응답 DTO 추가 .../dto/StoreDetailReadResponse.java	StoreDetailReadResponse 클래스 신규 생성. Store 상세 정보, 이미지, 부서명 포함. 정적 팩토리 메서드 fromEntity 구현.
서비스 인터페이스 반환 타입 변경 .../service/StoreService.java	getStoreByStoreId 반환 타입을 StoreReadDto에서 StoreDetailReadResponse로 변경. 관련 import 추가.
서비스 구현 반환 타입 및 부서명 처리 추가 .../service/StoreServiceImpl.java	getStoreByStoreId 반환 타입 변경 및 부서명 조회 후 응답에 포함. DepartmentRepository 의존성 추가.

Sequence Diagram(s)

sequenceDiagram
    participant Controller
    participant StoreServiceImpl
    participant StoreRepository
    participant DepartmentRepository
    participant StoreImageRepository

    Controller->>StoreServiceImpl: getStoreByStoreId(storeId, memberDetails)
    StoreServiceImpl->>StoreRepository: findById(storeId)
    StoreServiceImpl->>StoreImageRepository: findAllByStoreId(storeId)
    StoreServiceImpl->>DepartmentRepository: findById(departmentId)
    StoreServiceImpl->>StoreDetailReadResponse: fromEntity(store, images, departmentName)
    StoreServiceImpl-->>Controller: StoreDetailReadResponse

Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Suggested reviewers

• HyemIin

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 951564f and 630c6ef.

📒 Files selected for processing (3)

• nowait-app-admin-api/src/main/java/com/nowait/applicationadmin/store/dto/StoreDetailReadResponse.java (1 hunks)
• nowait-app-admin-api/src/main/java/com/nowait/applicationadmin/store/service/StoreService.java (2 hunks)
• nowait-app-admin-api/src/main/java/com/nowait/applicationadmin/store/service/StoreServiceImpl.java (4 hunks)

✨ Finishing Touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch refactor/#174-waiting-refactoring

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai generate unit tests to generate unit tests for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.