Skip to content

refactor: 에러 메세지 수정 #201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Jjiggu merged 2 commits into from
Jul 31, 2025
Merged

refactor: 에러 메세지 수정 #201

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5e064ba
refactor(storePayment): 일부 오타 수정
Jjiggu Jul 31, 2025
e3fa454
refactor(storePayment): 에러 메시지 명확하게 변경
Jjiggu Jul 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions ...p-user-api/src/main/java/com/nowait/applicationuser/exception/GlobalExceptionHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,7 @@
package com.nowait.applicationuser.exception;

import static com.nowait.common.exception.ErrorMessage.*;
import static org.springframework.http.HttpStatus.FORBIDDEN;
import static org.springframework.http.HttpStatus.INTERNAL_SERVER_ERROR;
import static org.springframework.http.HttpStatus.BAD_REQUEST;
import static org.springframework.http.HttpStatus.NOT_FOUND;
import static org.springframework.http.HttpStatus.*;
import static org.springframework.http.HttpStatus.UNAUTHORIZED;

import java.util.Map;
Expand Down Expand Up @@ -35,6 +32,7 @@
import com.nowait.domaincorerdb.reservation.exception.ReservationNotFoundException;
import com.nowait.domaincorerdb.store.exception.StoreNotFoundException;
import com.nowait.domaincorerdb.store.exception.StoreWaitingDisabledException;
import com.nowait.domaincorerdb.storepayment.exception.StorePaymentNotFoundException;
import com.nowait.domaincorerdb.token.exception.BusinessException;
import com.nowait.domaincorerdb.user.exception.UserNotFoundException;
import com.nowait.domainuserrdb.bookmark.exception.AlreadyDeletedBookmarkException;
Expand Down Expand Up @@ -238,6 +236,14 @@ public ErrorResponse handleStoreNotFoundException(StoreNotFoundException e, WebR
return new ErrorResponse(e.getMessage(), STORE_NOT_FOUND.getCode());
}

@ResponseStatus(NO_CONTENT)
@ExceptionHandler(StorePaymentNotFoundException.class)
public ErrorResponse handleStorePaymentNotFoundException(StorePaymentNotFoundException e, WebRequest request) {
alarm(e, request);
log.error("handleStorePaymentNotFoundException", e);
return new ErrorResponse(e.getMessage(), STORE_PAYMENT_NOT_FOUND.getCode());
}

// 공통 에러 Map 생성
private static Map<String, String> getErrors(MethodArgumentNotValidException e) {
return e.getBindingResult()
Expand Down
5 changes: 2 additions & 3 deletions .../main/java/com/nowait/applicationuser/storepayment/controller/StorePaymentController.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,13 +44,12 @@ public ResponseEntity<?> getStorePaymentByStoreId(@PathVariable Long storeId) {
);
} else {
return ResponseEntity
.status(HttpStatus.NO_CONTENT)
.status(HttpStatus.OK)
.body(
ApiUtils.success(
response
"해당 주점의 등록된 결제 정보가 존재하지 않습니다."
)
);
}

}
}
2 changes: 1 addition & 1 deletion ...n/java/com/nowait/domaincorerdb/storePayment/exception/StorePaymentNotFoundException.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,6 @@

public class StorePaymentNotFoundException extends RuntimeException {
public StorePaymentNotFoundException() {
super(ErrorMessage.STORE_PAYMENT_PARAMETER_EMPTY.getMessage());
super(ErrorMessage.STORE_PAYMENT_NOT_FOUND.getMessage());
}
}