Skip to content

Fix: 오타 및 구체적 에러로그 처리#57

Merged
Jjiggu merged 3 commits into
developfrom
fix/#44-multi-module-refactor
Jul 4, 2025
Merged

Fix: 오타 및 구체적 에러로그 처리#57
Jjiggu merged 3 commits into
developfrom
fix/#44-multi-module-refactor

Conversation

@Jjiggu

@Jjiggu Jjiggu commented Jul 4, 2025

Copy link
Copy Markdown
Contributor

작업 요약

  • jet 토큰 에러 로그 구체화
  • bookmark 참조 비교에서 값 비교로 변경

Issue Link

문제점 및 어려움

해결 방안

Reference

Summary by CodeRabbit

  • 버그 수정

    • 인증 및 토큰 관련 로그 메시지가 더욱 상세하고 명확하게 개선되었습니다. 만료된 토큰, 잘못된 토큰, 인증 성공 시 요청 URI, 사용자 정보 등이 로그에 포함됩니다.
    • 토큰 검증 메서드의 반환 타입이 일관성 있게 boolean으로 변경되었습니다.
  • 문서화

    • 향후 코드 이전 및 공통 모듈화를 위한 주석이 추가되었습니다.

Jjiggu added 3 commits July 4, 2025 23:08
- jwt 토큰 에러 로그 구체화
- bookmark 참조비교에서 값비교로 변경
@Jjiggu Jjiggu self-assigned this Jul 4, 2025
@coderabbitai

coderabbitai Bot commented Jul 4, 2025

Copy link
Copy Markdown

Caution

Review failed

The pull request is closed.

Walkthrough

이번 변경에서는 주요 로그 메시지의 상세화 및 로그 레벨 조정, 토큰 검증 메서드 시그니처의 원시 타입 반환으로의 변경, 그리고 특정 enum 클래스에 향후 작업을 위한 주석 추가가 이루어졌습니다. 전체적으로 코드의 동작 방식에는 변화가 없으며, 내부 로직과 진단 정보를 강화하는 개선입니다.

Changes

파일(그룹) 경로 변경 요약
.../JwtAuthorizationFilter.java 로그 메시지 상세화, 로그 레벨 조정, userId/role null 체크 및 경고 로그 추가
.../TokenService.java validateToken 반환 타입 Boolean→boolean, 로그 메시지 상세화 및 레벨 조정
.../OrderStatus.java 클래스 상단에 향후 작업 관련 주석 추가, 기능적 변화 없음

Sequence Diagram(s)

sequenceDiagram
    participant Client
    participant JwtAuthorizationFilter
    participant TokenService
    participant DB

    Client->>JwtAuthorizationFilter: HTTP 요청 (Authorization 헤더 포함)
    JwtAuthorizationFilter->>JwtAuthorizationFilter: Authorization 헤더 검증 및 상세 로그 기록
    alt 토큰 만료/유효성 실패/카테고리 불일치
        JwtAuthorizationFilter-->>Client: 401 Unauthorized 및 경고 로그
    else 토큰 정상
        JwtAuthorizationFilter->>TokenService: validateToken(token, userId)
        TokenService->>DB: 사용자 refresh token 조회
        alt 토큰 불일치/만료/없음
            TokenService-->>JwtAuthorizationFilter: false (상세 로그)
            JwtAuthorizationFilter-->>Client: 401 Unauthorized
        else 토큰 유효
            TokenService-->>JwtAuthorizationFilter: true (성공 로그)
            JwtAuthorizationFilter->>JwtAuthorizationFilter: 인증 컨텍스트 설정, 상세 성공 로그
            JwtAuthorizationFilter-->>Client: 정상 응답
        end
    end
Loading

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 652432f and 88707be.

📒 Files selected for processing (3)
  • nowait-app-user-api/src/main/java/com/nowait/applicationuser/security/jwt/JwtAuthorizationFilter.java (4 hunks)
  • nowait-app-user-api/src/main/java/com/nowait/applicationuser/token/service/TokenService.java (1 hunks)
  • nowait-domain/domain-core-rdb/src/main/java/com/nowait/domaincorerdb/order/entity/OrderStatus.java (1 hunks)
✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions Bot requested a review from HyemIin July 4, 2025 14:16
@Jjiggu Jjiggu merged commit 1ccb854 into develop Jul 4, 2025
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant