Integrate UNEP Environmental Data API#33
Merged
GYFX35 merged 1 commit intofeat/initial-project-structurefrom Feb 7, 2026
Merged
Integrate UNEP Environmental Data API#33GYFX35 merged 1 commit intofeat/initial-project-structurefrom
GYFX35 merged 1 commit intofeat/initial-project-structurefrom
Conversation
This change adds two new backend routes that fetch data for SDG indicators where UNEP is the custodian (recycling rate and protected areas). It also adds a new frontend page to visualize this data using Chart.js. - Added `/api/unep_recycling` and `/api/unep_protected_areas` in `app.py`. - Created `unep.html`, `unep.js`, and `unep.css` in `static/`. - Updated `index.html` with a link to the new page. - Added timeouts to the new backend API requests. Co-authored-by: GYFX35 <134739293+GYFX35@users.noreply.github.com>
Contributor
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Deploying success with
|
| Latest commit: |
0ee4f9a
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://69f4c7ba.success-a2i.pages.dev |
| Branch Preview URL: | https://integrate-unep-api-131347888.success-a2i.pages.dev |
Reviewer's GuideAdds backend UNEP-powered SDG endpoints for recycling rates and protected areas coverage, and a new frontend UNEP page that visualizes the top 10 countries for each indicator using Chart.js, linked from the main index page. Sequence diagram for fetching UNEP SDG data and rendering chartssequenceDiagram
actor User
participant Browser
participant FlaskBackend
participant UN_SDG_API
User->>Browser: Open unep.html
Browser->>FlaskBackend: GET /api/unep_recycling
FlaskBackend->>UN_SDG_API: GET /sdg/Series/Data?seriesCode=EN_MWT_RCYR
UN_SDG_API-->>FlaskBackend: JSON series data
FlaskBackend->>FlaskBackend: Extract latest per country
FlaskBackend->>FlaskBackend: Sort and select top 10
FlaskBackend-->>Browser: JSON top_10_recycling
Browser->>Browser: renderChart(recyclingChart, top_10_recycling)
Browser->>FlaskBackend: GET /api/unep_protected_areas
FlaskBackend->>UN_SDG_API: GET /sdg/Series/Data?seriesCode=ER_PTD_TERR
UN_SDG_API-->>FlaskBackend: JSON series data
FlaskBackend->>FlaskBackend: Extract latest per country
FlaskBackend->>FlaskBackend: Sort and select top 10
FlaskBackend-->>Browser: JSON top_10_protected_areas
Browser->>Browser: renderChart(protectedAreasChart, top_10_protected_areas)
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey - I've found 1 issue, and left some high level feedback:
- The two UNEP backend endpoints contain nearly identical request/transform/sort logic; consider extracting a shared helper function that takes series code and logging metadata to reduce duplication and make future indicator additions easier.
- In both UNEP endpoints, handle non-2xx responses explicitly (e.g., via
response.raise_for_status()or checkingresponse.ok) before callingresponse.json()so that upstream HTTP errors are surfaced more clearly and consistently. - On the frontend, the fetch helpers in
unep.jsassumeresponse.json()will succeed; you may want to guard against non-JSON or error status responses (e.g., by checkingresponse.okand logging or showing a simple user-facing message) to make failures easier to debug.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The two UNEP backend endpoints contain nearly identical request/transform/sort logic; consider extracting a shared helper function that takes series code and logging metadata to reduce duplication and make future indicator additions easier.
- In both UNEP endpoints, handle non-2xx responses explicitly (e.g., via `response.raise_for_status()` or checking `response.ok`) before calling `response.json()` so that upstream HTTP errors are surfaced more clearly and consistently.
- On the frontend, the fetch helpers in `unep.js` assume `response.json()` will succeed; you may want to guard against non-JSON or error status responses (e.g., by checking `response.ok` and logging or showing a simple user-facing message) to make failures easier to debug.
## Individual Comments
### Comment 1
<location> `eco_project/backend/app.py:749-753` </location>
<code_context>
+ year = entry['timePeriodStart']
+ value = entry['value']
+
+ if value is not None and (country not in latest_data or year > latest_data[country]['year']):
+ latest_data[country] = {
+ 'country': country,
+ 'year': int(year),
+ 'value': float(value)
+ }
+
</code_context>
<issue_to_address>
**issue (bug_risk):** Comparison between `year` (string) and stored `year` (int) will raise a TypeError.
`year` comes directly from the API as a string, while `latest_data[country]['year']` is stored as `int(year)`. On subsequent iterations this makes `year > latest_data[country]['year']` a string-vs-int comparison in Python 3. Convert `year` once (e.g. `year_int = int(year)`) and use `year_int` both in the comparison and when storing it.
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Comment on lines
+749
to
+753
| if value is not None and (country not in latest_data or year > latest_data[country]['year']): | ||
| latest_data[country] = { | ||
| 'country': country, | ||
| 'year': int(year), | ||
| 'value': float(value) |
There was a problem hiding this comment.
issue (bug_risk): Comparison between year (string) and stored year (int) will raise a TypeError.
year comes directly from the API as a string, while latest_data[country]['year'] is stored as int(year). On subsequent iterations this makes year > latest_data[country]['year'] a string-vs-int comparison in Python 3. Convert year once (e.g. year_int = int(year)) and use year_int both in the comparison and when storing it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Integrated UNEP environmental data by leveraging the UN SDG API. Added backend endpoints to fetch recycling rates and protected areas coverage, and a new frontend page with interactive charts to display this information. Verified the changes with backend tests and frontend screenshots.
PR created automatically by Jules for task 13134788857640065043 started by @GYFX35
Summary by Sourcery
Integrate UNEP SDG environmental indicators into the app with backend APIs and a new frontend visualization page.
New Features:
Enhancements: