Conversation
There was a problem hiding this comment.
Review: Approve ✓
This is a well-structured documentation addition that clearly explains the manual release process.
What's Good
- Clear step-by-step workflow with numbered steps
- Includes all necessary commands (version bump, build, DMG creation, GitHub release)
- Documents the code signing situation and the required
xattrworkaround for users - Consistent with existing CLAUDE.md formatting and tone
Minor Observations (non-blocking)
- The DMG output path uses
/tmp/which works but could be noted that this is ephemeral - fine as-is since it's just a staging location before upload. - The
--notesplaceholder ingh release createis a good reminder to add real notes.
No bugs, no security issues, no code changes to test. LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
gh release createTest plan