Skip to content

fix: cap HTTP response buffer at 512 KB to prevent OOM on Pi #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
GageLawton merged 1 commit into from
May 27, 2026
Merged

fix: cap HTTP response buffer at 512 KB to prevent OOM on Pi #110

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions src/weather.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,9 +26,18 @@ std::string urlEncode(const std::string& value) {
return escaped.str();
}

constexpr size_t MAX_RESPONSE_BYTES = 512 * 1024; // 512 KB; weatherapi.com responses are ~10 KB

size_t writeCallback(void* contents, size_t size, size_t nmemb, void* userp) {
static_cast<std::string*>(userp)->append(static_cast<char*>(contents), size * nmemb);
return size * nmemb;
auto* buf = static_cast<std::string*>(userp);
size_t incoming = size * nmemb;
if (buf->size() + incoming > MAX_RESPONSE_BYTES) {
LOG_ERROR("Weather API response exceeds " << (MAX_RESPONSE_BYTES / 1024)
<< " KB — aborting fetch");
return 0; // signals libcurl to abort with CURLE_WRITE_ERROR
}
buf->append(static_cast<char*>(contents), incoming);
return incoming;
}

// Helper: safely extract a string from a JSON value, returning fallback on missing/null.
Expand Down
Loading