-
Notifications
You must be signed in to change notification settings - Fork 3
👷 build: update nox #29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR updates the build and development tooling infrastructure, primarily migrating nox sessions to use nox-uv for improved dependency management. It also adds mypy for type checking and reorganizes the project configuration.
Key changes:
- Integrates
nox-uvfor better UV package manager integration in nox sessions - Adds mypy to the linting pipeline for static type checking
- Reorganizes pyproject.toml tool configurations for better readability
- Updates CI workflows to use the new nox-based approach
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
uv.lock |
Adds new dependencies: build, mypy, nox-uv, librt, mypy-extensions, pathspec, and pyproject-hooks |
pyproject.toml |
Adds build and nox dependency groups, includes mypy in lint group, reorganizes tool configuration sections for better logical grouping |
noxfile.py |
Refactors to use nox-uv with @session decorator, replaces direct uv run commands with session methods, adds mypy session |
src/diffraxtra/_src/diffeq_abc.py |
Removes strict=True parameter from eqx.Module (likely for compatibility) |
.pre-commit-config.yaml |
Updates codespell to read configuration from pyproject.toml instead of inline args |
.github/workflows/ci.yml |
Updates to use nox sessions instead of direct uv/pytest commands, renames job from checks to tests, adds status check job |
.github/workflows/cd.yml |
Adds persist-credentials: false for security hardening |
Signed-off-by: nstarman <nstarman@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #29 +/- ##
=======================================
Coverage ? 97.82%
=======================================
Files ? 5
Lines ? 184
Branches ? 0
=======================================
Hits ? 180
Misses ? 4
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: nstarman <nstarman@users.noreply.github.com>
Co-authored-by: Nathaniel Starkman <nstarman@users.noreply.github.com>
No description provided.