feat: integrate crane library and enhance Rust build configuration#633
Open
arunabha003 wants to merge 8 commits intoGaloyMoney:mainfrom
Open
feat: integrate crane library and enhance Rust build configuration#633arunabha003 wants to merge 8 commits intoGaloyMoney:mainfrom
arunabha003 wants to merge 8 commits intoGaloyMoney:mainfrom
Conversation
Member
|
I'm unable to build the binary, logs below: |
| local-daemon: | ||
| SIGNER_ENCRYPTION_KEY="0000000000000000000000000000000000000000000000000000000000000000" \ | ||
| cargo run --bin bria daemon --config ./bats/bria.local.yml run | ||
| cargo run --bin bria daemon --config ./bats/bria.local.yml run |
Contributor
There was a problem hiding this comment.
should this not be using nix now ?
Member
@arunabha003 I think I found the reason for the error above. I am running nix in a sandboxed mode, and network access is disabled during the build phase. Maybe sandboxed mode is set to false on your system. Can you share the output of |
Author
Yes the Sandbox mode appears to be set false in my system...Should I try to make it true? |
krtk6160
reviewed
Aug 6, 2025
Comment on lines
+55
to
+64
|
|
||
| nix-shell: | ||
| nix develop | ||
|
|
||
| nix-show: | ||
| nix flake show | ||
|
|
||
| # Run the application | ||
| run: | ||
| nix run |
Member
There was a problem hiding this comment.
I think we can remove these three targets
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR integrates the Crane library into Bria’s Nix setup and strengthens the Rust build/check pipeline around reproducible package builds and repository-level checks.
Implemented in this PR:
flake.nixto build Rust dependencies separately and then build the package via CraneMakefileandbuild.rs-related configuration to fit the new build path