Fix city generation and rendering issues #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit addresses two critical issues: 1. An intermittent 'Unable to build a street!' error that caused the application to crash during city generation. This was traced to a pathfinding failure when gate vertices were smoothed. The fix makes the pathfinding algorithm more robust by finding the closest node instead of requiring an exact match. 2. A rendering problem where the generated map would not appear on the screen. This was due to the lack of canvas transformations. The fix adds scaling and translation to the canvas context, ensuring the city is properly centered and visible. Additionally, the development environment was fixed by adding missing dependencies to the `web/package.json` file. Note: The project appears to be missing its test files, so the changes could not be verified with automated tests.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes a crash during city generation and a rendering bug that prevented the map from being displayed. It also resolves dependency issues in the development environment.