🧪 Add missing error path test for loadFormats - #16
Conversation
This commit adds a test file (`docs/index.test.js`) which verifies that when the fetch for the format database fails, the fallback formats (PNG, JPG, WEBP, PDF) are properly loaded in the application. It installs `jest` and `jest-environment-jsdom` to support this DOM testing via jsdom evaluation of the embedded HTML scripts. Co-authored-by: paul0728 <44644609+paul0728@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
🎯 What: The testing gap addressed
The
loadFormatsfunction indocs/index.htmlfetches the database of formats (format_database.json). If this fetch fails, the function catches the error and provides a default list of basic formats (PNG, JPG, WEBP, PDF). This error path had no test coverage.📊 Coverage: What scenarios are now tested
A new Jest test was introduced that mocks
fetchto simulate a network rejection (specifically forformat_database.json). We verify that:targetFormatSelectelement falls back to the hard-coded default extensions.fileInput.acceptattribute correctly restricts options to standard types (.png,.jpg,.jpeg,.webp,.pdf).✨ Result: The improvement in test coverage
We now guarantee via CI/tests that the app won't completely crash or freeze if it cannot load its config JSON, providing peace of mind during future refactors to the UI parsing logic.
PR created automatically by Jules for task 2747153102781428553 started by @paul0728