🔒 Add Subresource Integrity (SRI) hashes for external resources - #19
🔒 Add Subresource Integrity (SRI) hashes for external resources#19paul0728 wants to merge 1 commit into
Conversation
Added Subresource Integrity (SRI) hashes to: - The JSZip CDN script tag - The fetch call for the magick.wasm WebAssembly binary This mitigates the risk of a compromised CDN serving malicious code. Co-authored-by: paul0728 <44644609+paul0728@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
🎯 What:
Added missing Subresource Integrity (SRI) hashes when fetching external dependencies in
docs/index.html.<script>tag loading JSZip.fetchoptions formagick.wasm.If the external CDN (
unpkg.comorcdnjs.cloudflare.com) was compromised or subject to a Man-In-The-Middle (MITM) attack, malicious code could be injected into the application. For the WASM binary, executing untrusted code within the browser context poses significant cross-site scripting (XSS) and remote code execution risks depending on browser zero-days.🛡️ Solution:
Calculated the SHA-384 hashes for
magick.wasmandjszip.min.js. Modified the respective fetch call and script tag to include theintegrityoption/attribute. This leverages native browser features to guarantee the fetched resources perfectly match the expected original files, aborting execution if they have been tampered with. Verified that the engine still initializes correctly using a headless Puppeteer browser test checking for SRI console errors.PR created automatically by Jules for task 768050110757342917 started by @paul0728