Skip to content

🔒 Fix potential Path Traversal (ZIP Slip) via unsanitized filename - #3

Open
paul0728 wants to merge 1 commit into
mainfrom
fix-zip-slip-vulnerability-3122588427105292072
Open

🔒 Fix potential Path Traversal (ZIP Slip) via unsanitized filename#3
paul0728 wants to merge 1 commit into
mainfrom
fix-zip-slip-vulnerability-3122588427105292072

Conversation

@paul0728

Copy link
Copy Markdown
Collaborator

🎯 What: A Path Traversal (ZIP Slip) vulnerability in docs/index.html where an unsanitized filename from the input File object was used directly to construct the filename in the generated ZIP file (zip.file(outFileName, ...)).
⚠️ Risk: If a malicious script constructed a File object with path components (e.g., ../../../evil.jpg) or an attacker manipulated the name attribute, the resulting ZIP file could extract files outside the intended directory. This can lead to arbitrary file write on the user's system upon extraction.
🛡️ Solution: Implemented filename sanitization in JavaScript using const sanitizedFileName = file.name.split(/[/\\]/).pop();. This safely strips all / and \ path components, guaranteeing only the base file name is processed before inserting into the ZIP archive. Tested locally using an automated JS test simulation.


PR created automatically by Jules for task 3122588427105292072 started by @paul0728

This commit modifies `docs/index.html` to sanitize user-provided file names before adding them to a generated ZIP file. By stripping directory path components (`/` and `\`), this prevents malicious file uploads (e.g., via a crafted File object representing a path like `../../../evil.jpg`) from attempting directory traversal during extraction, mitigating a ZIP Slip vulnerability.

Co-authored-by: paul0728 <44644609+paul0728@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant