Skip to content

🧪 Add tests for loadFormats function - #9

Open
paul0728 wants to merge 1 commit into
mainfrom
tests/load-formats-6577386116842439749
Open

🧪 Add tests for loadFormats function#9
paul0728 wants to merge 1 commit into
mainfrom
tests/load-formats-6577386116842439749

Conversation

@paul0728

Copy link
Copy Markdown
Collaborator

🎯 What: The testing gap addressed
This PR addresses the missing tests for the loadFormats function inside docs/index.html. Since the application logic resides mostly in inline module scripts, testing required setting up jest and jsdom, manually instantiating a DOM, mocking global implementations of fetch, and handling ESM script evaluation correctly within the JSDOM context.

📊 Coverage: What scenarios are now tested

  • Happy Path: Ensures the function successfully fetches format_database.json, parses it, and correctly populates the DOM elements (restricting the accept attribute of fileInput and adding the write-supported formats to the targetFormat dropdown options, e.g., excluding heic).
  • Network Error: Ensures the function gracefully falls back to basic formats (png, jpg, webp, pdf) when the fetch request encounters a network error (simulated via response.ok = false).
  • Malformed JSON: Ensures the function gracefully handles invalid JSON responses as a fallback, similarly populating the default basic formats.

Result: The improvement in test coverage
The frontend's initial bootstrap flow is now verified, ensuring robustness against backend/network/JSON failures and that valid formats properly propagate from the database file to the web UI options.


PR created automatically by Jules for task 6577386116842439749 started by @paul0728

Co-authored-by: paul0728 <44644609+paul0728@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant