Skip to content

fix: auto-correct invalid MIFARE Classic ACL and block dangerous ACL before writing#858

Open
azuwis wants to merge 1 commit intoGameTec-live:mainfrom
azuwis:add-acl-validation
Open

fix: auto-correct invalid MIFARE Classic ACL and block dangerous ACL before writing#858
azuwis wants to merge 1 commit intoGameTec-live:mainfrom
azuwis:add-acl-validation

Conversation

@azuwis
Copy link
Copy Markdown
Contributor

@azuwis azuwis commented May 6, 2026

Two-layer protection matching Proxmark3's hf mf wrbl behavior:

  1. Invalid ACL (complement-bit mismatch, e.g. 000000): auto-corrected to FF 07 80 69 — card is always writable.

  2. Dangerous ACL (valid but would permanently lock blocks): write is blocked entirely unless the "Disable ACL safety check" toggle is enabled (equivalent to Proxmark3's --force flag).

…before writing

Two-layer protection matching Proxmark3's hf mf wrbl behavior:

1. Invalid ACL (complement-bit mismatch, e.g. 000000):
   auto-corrected to FF 07 80 69 — card is always writable.

2. Dangerous ACL (valid but would permanently lock blocks):
   write is blocked entirely unless the "Disable ACL safety check"
   toggle is enabled (equivalent to Proxmark3's --force flag).
@github-actions github-actions Bot added the translation changes When something in the translation changes label May 6, 2026
Copy link
Copy Markdown
Owner

@GameTec-live GameTec-live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this blocks the write when a dangerous ACL is detected unless explicitly bypassed via the checkbox? And it doesnt autocorrect / change the data?

});
}

Widget _buildForceWriteToggle() {
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we sure we want this as a function? Wouldnt it make more sense as a stand alone stateful or stateless widget?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

translation changes When something in the translation changes

Projects

Status: Todo

Development

Successfully merging this pull request may close these issues.

2 participants