Issue #33, decrease bundle size by using lottie light#86
Open
summerliu wants to merge 2 commits intoGamote:mainfrom
Open
Issue #33, decrease bundle size by using lottie light#86summerliu wants to merge 2 commits intoGamote:mainfrom
summerliu wants to merge 2 commits intoGamote:mainfrom
Conversation
added 2 commits
March 21, 2023 13:54
# Conflicts: # build/index.d.ts # build/index.es.js # build/index.es.js.map # build/index.es.min.js # build/index.js # build/index.js.map # build/index.min.js # build/index.umd.js # build/index.umd.js.map # build/index.umd.min.js
|
bump |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My team ran into this issue #33 as well. The lottie bundle size was initially 3.81MB.(see image below)
And after implemented it with lottie light, it did reduced to 2.86MB.(also see image below)
This implementation could refer to https://github.com/dilan-dio4/lottie-light-react/commit/28c5bcbadcbc2b06dc92e0d2d1be1e20c64d5c1d#diff-0b5adbfe7b36e4ae2f479291e20152e33e940f7f265162d77f40f6bdb5da7405 by @dilan-dio4
Let me know if there is any question. Thanks!