fix: switch to promises to prevent locking on windows os#5
Merged
GangGreenTemperTatum merged 1 commit intomainfrom Oct 23, 2025
Merged
fix: switch to promises to prevent locking on windows os#5GangGreenTemperTatum merged 1 commit intomainfrom
GangGreenTemperTatum merged 1 commit intomainfrom
Conversation
There was a problem hiding this comment.
Pull Request Overview
Refactors file system operations from synchronous to asynchronous to prevent file locking issues on Windows OS.
- Replaced synchronous fs functions (
accessSync,readdirSync,statSync) with async alternatives fromfs/promises - Updated
pathExists,scanDirectoryfunctions to be async and return promises - Added proper
awaitkeywords for all async function calls throughout the file
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: switch to promises to prevent locking on windows os
Key Changes:
fsspecfile locking #4 and issues reported by Amr / SyttenChanged:
- accessSync, readdirSync, statSync → access, readdir, stat from fs/promises
- Now returns Promise instead of boolean
- Uses await access() instead of accessSync()
- scanDirectory is now async and returns Promise
- Uses await readdir() instead of readdirSync()
- Uses await stat() instead of statSync()
- Added await for recursive calls to scanDirectory()
- Added await when calling pathExists()
- Added await when calling scanDirectory()
@Sytten @amrelsagaei could i ask if you had 5 mins for a quick PR review on this please? tested and works in my VM but i don't have Windows hardware
Generated Summary
This summary was generated with ❤️ by rigging