Build and lint assets in CI#42
Merged
Merged
Conversation
The asset pipeline had no continuous check: nothing built the bundle or ran the JavaScript and stylesheet linters on a push, so a broken build would only surface at release. This adds a dedicated workflow that installs from the committed lockfile, lints, and builds.
Thirty-three resolved URLs had been written against a local registry proxy when the lockfile was first generated, so npm ci fetched those tarballs from a host CI cannot reach and failed with a 418. Rewriting them to registry.npmjs.org leaves the integrity hashes untouched.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The asset pipeline arrived without a continuous check of its own. The release workflow builds the bundle on tag, but nothing verified on a push that the JavaScript still compiles or that the source passes the linters, so a broken build would have surfaced only at release time.
This adds a focused Assets workflow that installs from the committed lockfile, lints the JavaScript and stylesheets, and runs the production build. It sits alongside the PHP CI rather than inside it: the build is a Node concern with its own toolchain, and keeping it separate avoids entangling it with the wp-env matrix.