Open
Conversation
bob8dod
requested changes
Dec 29, 2024
| public void retrieveKakaoOauthAuthorization(HttpServletResponse httpServletResponse) { | ||
| String requestUrl = String.format( | ||
| "%s?response_type=%s&client_id=%s&redirect_uri=%s", | ||
| kakaoOauthUrl, "code", clientId, redirectUri |
Contributor
There was a problem hiding this comment.
"code" 는 string 안에 넣어도 되지 않을까요? 굳이 변수로 빼낸 이유가 있나요?
| @Override | ||
| public void checkKakaoOauthUser(String accessToken) { | ||
| try { | ||
| KakaoOauthUserInfoResp kakaoOauthUserInfoResp = kakaoOauthClient.getUserInfo(accessToken); |
Contributor
There was a problem hiding this comment.
getUserInfo() 는 직접 생성된 client의 메서드인데, 왜 try catch를 여기서 하는거죠?
getUserInfo() 내부에서 이루어져야될 것 같습니다. 만약 필요하다면
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
연관 이슈
리뷰 요구사항