Skip to content

Fix ParticleHP fission nubar evaluated at wrong energy in const getters #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ibrahmkocaa wants to merge 1 commit into
base: master
Choose a base branch
from
+10 −3
Open

Fix ParticleHP fission nubar evaluated at wrong energy in const getters #103

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions source/processes/hadronic/models/particle_hp/include/G4ParticleHPParticleYield.hh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,11 +105,18 @@ class G4ParticleHPParticleYield
}
}

// The interpolating G4ParticleHPVector::GetY(G4double) overload is
// non-const, so on the const-qualified member vectors below overload
// resolution used to fall back silently to GetY(G4int) const via an
// implicit double->int conversion: the fission neutron yield was read
// as "y of table point floor(E)" - i.e. the thermal nubar for all
// reactor-relevant energies - instead of nubar(E). The const_casts
// restore the energy-interpolating lookup.
inline G4double GetMean(G4double anEnergy) const
{
if (simpleMean)
{
return theSimpleMean.GetY(anEnergy);
return const_cast<G4ParticleHPVector&>(theSimpleMean).GetY(anEnergy);
}
return theMean.GetValue(anEnergy);
}
Expand All @@ -121,7 +128,7 @@ class G4ParticleHPParticleYield
{
return theSpontPrompt;
}
return thePrompt.GetY(anEnergy);
return const_cast<G4ParticleHPVector&>(thePrompt).GetY(anEnergy);
}

inline G4double GetDelayed(G4double anEnergy) const
Expand All @@ -131,7 +138,7 @@ class G4ParticleHPParticleYield
{
return theSpontDelayed;
}
return theDelayed.GetY(anEnergy);
return const_cast<G4ParticleHPVector&>(theDelayed).GetY(anEnergy);
}

inline G4double GetDecayConstant(G4int i) const
Expand Down