451: Support for different priors#468
Merged
Merged
Conversation
Contributor
Unit Tests Summary 1 files 195 suites 7m 38s ⏱️ Results for commit a74af59. ♻️ This comment has been updated with latest results. |
Contributor
Unit Test Performance Difference
Additional test case details
Results for commit c5d3e12 ♻️ This comment has been updated with latest results. |
…f it makes a difference
Contributor
Code Coverage SummaryDiff against mainResults for commit: 7b0d59d Minimum allowed coverage is ♻️ This comment has been updated with latest results |
mercifr1
approved these changes
Jun 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #451
For the survival models, we can set different independent normal priors for the coefficients of the covariates in the linear predictor using the
prior_normal_vector()specification. Here we can give a vector of the same length as the number of design matrix columns for both the means or standard deviations of the normal distributions, or we can give a single value that will be repeated for all covariates.For example, say we have 3 design matrix columns, i.e. coefficients, in the linear predictor of the survival model, then we can set the priors for these coefficients as follows:
You can run
on a
DataJointobject to know the columns of the design matrix and then match the positions. This is kind of a workaround but is already practical to use now. More sophisticated solution might come from #11To do: