Skip to content

fix: redact RNG seed from HTTP response logging in release builds #550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
x64-dev merged 1 commit into from
Aug 8, 2026
+12 −0
Merged

fix: redact RNG seed from HTTP response logging in release builds #550

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions GeneralsMD/Code/GameEngine/Source/GameNetwork/GeneralsOnline/HTTP/HTTPRequest.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,6 +208,18 @@ void HTTPRequest::Threaded_SetComplete(CURLcode result)
// if we got an error, set the response code to 0

#if !_DEBUG
static const std::string strSeedKey = "\"RNGSeed\":";
for (size_t seedPos = strResponse.find(strSeedKey); seedPos != std::string::npos; seedPos = strResponse.find(strSeedKey, seedPos))
{
size_t valueStart = seedPos + strSeedKey.length();
size_t valueEnd = strResponse.find_first_of(",}", valueStart);
if (valueEnd == std::string::npos)
break;

strResponse.replace(valueStart, valueEnd - valueStart, "<redacted>");
seedPos = valueStart;
}

std::transform(strResponse.begin(), strResponse.end(), strResponse.begin(),
[](unsigned char c) { return std::tolower(c); });
if (strResponse.find("token") != std::string::npos)
Expand Down
Loading