fix(team): Prevent crash when createInactiveTeam returns null - #551
Open
seer-by-sentry[bot] wants to merge 1 commit into
Open
fix(team): Prevent crash when createInactiveTeam returns null#551seer-by-sentry[bot] wants to merge 1 commit into
seer-by-sentry[bot] wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses CLIENT-38X, a crash in
TeamFactory::createTeam.Root Cause:
The
TeamFactory::createTeamfunction was observed to crash whencreateInactiveTeam()returned a null pointer, andsetActive()was subsequently called on this null pointer. This issue stemmed from an incomplete application (or subsequent reversion) of a previous fix (PR 534 / commit362de7da). While the null check was correctly applied toGenerals/Code/GameEngine/Source/Common/RTS/Team.cpp, it was missing or reverted in the parallelGeneralsMD/Code/GameEngine/Source/Common/RTS/Team.cppfile.Solution:
Implemented a null check for the return value of
createInactiveTeam()before callingsetActive()withinTeamFactory::createTeaminGeneralsMD/Code/GameEngine/Source/Common/RTS/Team.cpp. The same null check was also verified and re-applied toGenerals/Code/GameEngine/Source/Common/RTS/Team.cppto ensure consistency across both code paths and prevent future regressions.Fixes CLIENT-38X