Handle unmapped client IDs and respect disabled match uploads - #30
Open
tintinhamans wants to merge 3 commits into
Open
Handle unmapped client IDs and respect disabled match uploads#30tintinhamans wants to merge 3 commits into
tintinhamans wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MatchData.upload_match_databefore initializing the S3 client.Enum.TryParseaccepts values such asunknownand arbitrary numeric values. These values were not present in the known-client session mapping, causing the login request to return HTTP 500.The match-data upload toggle was also not honored during S3 initialization or URL generation. Disabling uploads still required valid S3 configuration and attempted to generate upload URLs.