Skip to content

Handle unmapped client IDs and respect disabled match uploads - #30

Open
tintinhamans wants to merge 3 commits into
GeneralsOnlineDevelopmentTeam:mainfrom
tintinhamans:arctic/updates
Open

Handle unmapped client IDs and respect disabled match uploads#30
tintinhamans wants to merge 3 commits into
GeneralsOnlineDevelopmentTeam:mainfrom
tintinhamans:arctic/updates

Conversation

@tintinhamans

Copy link
Copy Markdown
Contributor
  • Handle enum-compatible but unmapped client IDs without returning HTTP 500.
  • Respect MatchData.upload_match_data before initializing the S3 client.
  • Skip presigned URL generation when match uploads are disabled.
  • Return empty upload URLs in lobby and WebSocket responses when uploads are unavailable.

Enum.TryParse accepts values such as unknown and arbitrary numeric values. These values were not present in the known-client session mapping, causing the login request to return HTTP 500.

The match-data upload toggle was also not honored during S3 initialization or URL generation. Disabling uploads still required valid S3 configuration and attempted to generate upload URLs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant