Skip to content

client handoff#349

Merged
in-mai-space merged 14 commits into
mainfrom
first-polish
May 2, 2026
Merged

client handoff#349
in-mai-space merged 14 commits into
mainfrom
first-polish

Conversation

@in-mai-space
Copy link
Copy Markdown
Contributor

@in-mai-space in-mai-space commented May 2, 2026

  • fix bottom sheet not working
  • fix activity card to full height
  • fix layout for settings
  • pas trip compact card
  • fix destination picker stuff
  • remove map and view on map button instead
  • fix map issues
  • fix the back button and burger no working
  • done
  • format and lint
  • handoff doc
  • done
  • done
  • edit title

User-visible changes

  • Bottom sheets now display with properly configured snap points (DeleteAccountSheet: 400px, LogoutSheet: 300px, MapView: 60%), fixing height and scroll behavior
  • Activity cards and past trip compact cards render with correct full-height layouts including proper image sizing and aspect ratios
  • Destination picker now captures and returns geographic coordinates (latitude/longitude) with location selections
  • Map preview inline with MapLibre removed; "View on map" button added for navigating to dedicated map view when coordinates available
  • Settings and activity detail navigation fixed with corrected BackButton import and explicit screen header configuration

Changes by category

Fixes:

  • Bottom sheet sizing and snap point configuration (delete-account-sheet, logout-sheet, map-view)
  • Settings layout navigation header and BackButton import path
  • Map opening behavior with error handling for native URL fallback (maps.ts)
  • Activity detail screen navigation with explicit Stack.Screen configuration

Improvements:

  • Past trip compact card layout with borderRadius, aspect ratio, and flex constraints
  • Activity card thumbnail sizing using dynamic aspect ratio instead of fixed dimensions
  • Location tag rendering with horizontal ScrollView to handle multiple tags
  • Destination picker coordinate extraction and payload structure
  • Bottom sheet handle styling (ModalHandle token application)
  • Comment section header simplified by removing drag handle

Features:

  • Entity detail screen location "View on map" button navigation flow
  • Memoized map provider resolution based on currentUser Apple/Google map settings

Infra:

  • HANDOFF.md documentation covering production services access, GitHub Actions secrets, local development setup, environment configuration, deployment procedures, and CI/CD workflows

Contribution summary

File Added Removed Net
HANDOFF.md 490 0 +490
entity-detail-screen.tsx 59 103 -44
map-view.tsx 28 15 +13
itinerary-activity-card.tsx 29 13 +16
activities/[id]/_layout.tsx 20 1 +19
past-trip-compact-card.tsx 14 5 +9
destination-picker-sheet.tsx 10 3 +7
delete-account-sheet.tsx 6 1 +5
logout-sheet.tsx 6 1 +5
maps.ts 11 2 +9
bottom-sheet.tsx 7 2 +5
settings/_layout.tsx 4 3 +1
types.ts 2 0 +2
comment-section.tsx 2 9 -7
Total +688 -158 +530

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 2, 2026

📝 Walkthrough

Walkthrough

This pull request adds location coordinate handling to trip and activity entities, removes permission-based editing restrictions, refines UI component styling and BottomSheet configurations, and introduces a comprehensive HANDOFF.md for project transfer. The coordinate system enables map-based navigation and location preview functionality.

Changes

Location Coordinates & Entity Location UI

Layer / File(s) Summary
Data Shape
frontend/app/(app)/components/types.ts
SelectedLocation extends to include lat: number and lng: number fields.
Coordinate Capture
frontend/app/(app)/components/destination-picker-sheet.tsx
Place selection now extracts latitude/longitude from Google Maps API response and passes coordinates in the onSelect callback alongside name and place_id.
Entity Location Display & Navigation
frontend/app/(app)/trips/[id]/components/entity-detail-screen.tsx
Removes canEdit permission prop and gating. Location section replaces MapLibre preview with a "View on map" button that navigates to /map-view when coordinates are available. Edit handlers now always function without permission checks.
Map View & Directions
frontend/app/(app)/map-view.tsx, frontend/utils/maps.ts
Map provider selection is memoized via useMemo. Directions-opening flow builds explicit params object. Google Maps fallback wraps Linking.canOpenURL in try/catch to handle errors gracefully.

UI Component Polish & Refinements

Layer / File(s) Summary
BottomSheet Handle Styling
frontend/design-system/components/bottom-sheet/bottom-sheet.tsx
Replaces handleComponent={null} with handleIndicatorStyle using design tokens ModalHandle and ColorPalette.gray300.
Sheet Configuration
frontend/app/(app)/components/delete-account-sheet.tsx, frontend/app/(app)/components/logout-sheet.tsx
Adds explicit snapPoints props ([400] and [300] respectively) and reformats JSX to multi-line prop lists.
Navigation & Header Config
frontend/app/(app)/settings/_layout.tsx, frontend/app/(app)/trips/[id]/activities/[id]/_layout.tsx
Updates BackButton import source to @/design-system. Adds explicit Stack.Screen definitions with header visibility and gesture configuration. Configures header back-button rendering.
Card & List Item Styling
frontend/app/(app)/components/home/past-trip-compact-card.tsx, frontend/app/(app)/trips/[id]/itinerary-tab/components/itinerary-activity-card.tsx
Refines flex layout, aspect ratios, and border radius for cover images. Replaces fixed thumbnail sizing with aspect-ratio-driven layout. Converts location tag row to horizontal ScrollView for overflow handling.
Comment Section Header
frontend/design-system/components/comments/comment-section.tsx
Removes draggable handle UI from modal header; simplifies to title-only header.

Project Documentation

Layer / File(s) Summary
Handoff Guide
HANDOFF.md
Comprehensive transfer documentation covering service account requirements, GitHub Actions secrets, local development prerequisites and environment setup, database/migration workflows, testing commands, infrastructure management, deployment procedures, and CI/CD mappings.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

  • trip creation ui/ux fixes #294: Extends the destination picker flow by adding lat/lng coordinate capture to SelectedLocation and updating the sheet's onSelect callback.
  • hot fix: create profile on home if user defined #302: Modifies BottomSheet usage across multiple components, adding snapPoints configuration alongside this PR's component updates.
  • feat: polishing #263: Overlaps on BottomSheet wiring and header navigation changes in the same component files (delete-account-sheet.tsx, logout-sheet.tsx, settings/_layout.tsx).

Suggested reviewers

  • aahiltn
  • anish-sahoo

Poem

📍 Coordinates now guide the way,
Permissions fall, restrictions sway,
Sheets snap crisp with handles styled,
Maps displayed and undo reconciled,
Handoff notes for journeys ahead.

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 40.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
Title check ❓ Inconclusive The title 'client handoff' is vague and does not clearly convey the main changes in the pull request, which involve UI fixes, component refactoring, and documentation. Provide a more specific title that reflects the primary change, such as 'Fix UI components and add project handoff documentation' or focus on the main change if one exists.
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch first-polish

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@in-mai-space in-mai-space changed the title first polish client handoff May 2, 2026
@in-mai-space in-mai-space merged commit 995531f into main May 2, 2026
9 of 10 checks passed
@in-mai-space in-mai-space deleted the first-polish branch May 2, 2026 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant