CLEAN: Remove the showcase popup on load#230
Open
josh-torre wants to merge 1 commit into
Open
Conversation
Contributor
👷 Deploy Preview for sprightly-manatee-243873 processing.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What did I do?
I removed the logic to display the popup for the showcase luma on the website on mount and restored Frank's comment about what to change to allow for it to be easily be changed in the future.
In the future, we should think about moving this to sanity but we should do the redesign first.
Required checks:
What could go wrong in the future? What parts of your code should the reviewer pay the most attention to?
Describe aspects of the PR that may become problems in the future.
Additional Comments for the Reviewers
Screenshots