[MISC] Disable perf dispatch re-benchmarking to reduce performance penalty.#2599
Merged
duburcqa merged 2 commits intoGenesis-Embodied-AI:mainfrom Mar 24, 2026
Conversation
|
🔴 Benchmark Regression Detected ➡️ Report |
hughperkins
approved these changes
Mar 24, 2026
Collaborator
hughperkins
left a comment
hughperkins
left a comment
There was a problem hiding this comment.
Given this improves FPS of most things by at least ~1-2%, some things by 5-10%, and 4 things by %10+, with only one thing (dex hand) showing a regression, -%10, I'm in favor of merging this PR.
We can deal with dex hand regression in the future somehow. Some options occur to me for dex hand:
- use cuda graph
- expose the perf dispatch repeat as a user-configurable option
- reduce the perf dispatch warmup time (eg using Genesis-Embodied-AI/quadrants#422 )
- and possibly reduce the perf dispatch active time
duburcqa
changed the title
duburcqa
approved these changes
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Resolves Genesis-Embodied-AI/Genesis#
Motivation and Context
How Has This Been / Can This Be Tested?
Screenshots (if appropriate):
Checklist:
Submitting Code Changessection of CONTRIBUTING document.