Skip to content

[Type] ndarray typing 2: Fix NDArray single-arg subscript crash #412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
hughperkins wants to merge 2 commits into
base: hp/typing-t4-1-eval-str
Choose a base branch
from
Draft

[Type] ndarray typing 2: Fix NDArray single-arg subscript crash #412

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
74dcea6
[Fix] Fix NDArray single-arg subscript crash
hughperkins Mar 12, 2026
050f3a7
[Test] Add test for single-arg NDArray subscript syntax
hughperkins Mar 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions python/quadrants/types/ndarray_type.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,8 +94,10 @@ def __init__(
self.boundary = int(to_boundary_enum(boundary))

@classmethod
def __class_getitem__(cls, args, **kwargs):
return cls(*args, **kwargs)
def __class_getitem__(cls, args):
if not isinstance(args, tuple):
args = (args,)
return cls(*args)

def check_matched(self, ndarray_type: NdarrayTypeMetadata, arg_name: str):
# FIXME(Haidong) Cannot use Vector/MatrixType due to circular import
Expand Down
6 changes: 6 additions & 0 deletions tests/python/test_ndarray_typing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,3 +16,9 @@ def test_ndarray_typing_square_brackets():
b[1, 1] = 5
some_kernel(a, b)
assert a[1, 1] == 5 + 2


def test_ndarray_typing_single_arg():
t = qd.types.NDArray[qd.i32]
assert t.dtype == qd.i32
assert t.ndim is None
Loading