feat(engram): add data-directory domain core#700
Open
tonyblu331 wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked Issue
Closes #346
PR Type
type:feature- Engram data-dir feature sliceMaintainer action required: add the
type:featurelabel. GitHub rejected label updates fromtonyblu331withAddLabelsToLabelablepermission errors.Summary
Adds the core Engram data-directory domain helpers now that the disk-space infrastructure slice (#638) is merged into
main.This slice keeps the chain reviewable: it only introduces default/custom data-dir references, database path helpers, copy behavior, environment overrides, and presentation helpers. It deliberately does not include service orchestration, location listing, TUI state, install-flow wiring, or unrelated Windows test stabilization.
Changes
internal/components/engram/copy.gointernal/components/engram/env.gointernal/components/engram/presenter.goTest Plan
Focused Local Unit Tests
Full Suite / CI
./internal/components/engram,./internal/storage).ubuntu,fedora,arch).type:*label check passes — pending maintainer-appliedtype:featurelabel.Local Windows full-suite note
I did not broaden this PR to fix unrelated local Windows baseline failures. I re-ran
go test -count=1 ./...from an LF checkout to avoid CRLF golden noise; it still fails locally in packages outside this slice. The same targeted failures reproduce on currentorigin/main(1f13b8d), so they are not caused by this PR:internal/cliTestRunInstallKimiMissingUVFailsBeforeExecutingInstallCommandsinternal/components/ggaTestInjectIsIdempotent/ first-run config-change expectationinternal/updateTestCheckSingleTool_EngramUsesBinaryReleaseChannelinternal/update/upgradeTestConfigPathsForBackup_GGAExtrasAreIncludedThose should be handled in a separate Windows test-stabilization PR if maintainers want local Windows
go test ./...green. This slice stays scoped to Engram data-dir domain helpers.Chain Context
feat/engram-dd-1-infra(#638, merged)fix/engram-dd-15-operation-consistencyfeat/engram-dd-2-domain-coremainat 2026-05-27 13:01:52 UTCfeat/engram-dd-3-domain-serviceafter this slice landsPlanned review order by branch:
Contributor Checklist
status:approvedtype:*label is applied (type:feature, maintainer action required)ubuntu,fedora,arch)Co-Authored-Bytrailers