Fix segmentation fault when ESS < 10 by raising ValueError (#47) #131
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description This PR fixes issue #47 where asking for a very low Effective Sample Size (ESS < 10) causes a segmentation fault in the underlying C++ library (volesti).
Changes :-
Added a validation check in PolytopeSampler.generate_steady_states() and get_polytope() to enforce ess >= 10.
Raises a clear ValueError if ess is too low, preventing the crash and informing the user about the minimum requirement to avoid numerical instability.
Verification :-
Created a reproduction script that attempts to run generate_steady_states(ess=5).
Verified that the segmentation fault is no longer triggered and that a ValueError is raised instead.