Add minimalist .xcodeproj so rnpm finds DeviceUtil.{h,m}#24
Open
peritus wants to merge 1 commit intoGertjanReynaert:masterfrom
peritus:rnpm
Open
Add minimalist .xcodeproj so rnpm finds DeviceUtil.{h,m}#24peritus wants to merge 1 commit intoGertjanReynaert:masterfrom peritus:rnpm
peritus wants to merge 1 commit intoGertjanReynaert:masterfrom
peritus:rnpm
Conversation
|
+1 |
Owner
|
@peritus Is this pr still valid for the current React Native version? |
Author
|
@GertjanReynaert I have no idea. I can rebase and test, there shouldn't be any dependencies on the react-native version, if you ask me. |
so rnpm finds DeviceUtil.{h,m}
Owner
|
@peritus I'm just asking because I'm not that familiar anymore with React Native. So if you could just validate that this works, then I'll merge it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #23