fix: post-merge/OAPI-reconciliation adjustments - #1812
Open
arnautov-anton wants to merge 1 commit into
Open
Conversation
arnautov-anton
changed the title
arnautov-anton
force-pushed
the
v10-post-merge-adjustments
branch
2 times, most recently
from
August 11, 2026 16:29
bf51d81 to
ccf70c0
Compare
arnautov-anton
force-pushed
the
v10-post-merge-adjustments
branch
from
August 11, 2026 16:32
ccf70c0 to
6257e5b
Compare
arnautov-anton
commented
Aug 11, 2026
|
|
||
| export const isLocalMessage = (message: unknown): message is LocalMessage => | ||
| isDate((message as LocalMessage).created_at); | ||
| typeof (message as LocalMessage | undefined)?.status === 'string'; |
Contributor
Author
There was a problem hiding this comment.
Important one to check, @isekovanic and @MartinCupela.
arnautov-anton
commented
Aug 11, 2026
Comment on lines
-1110
to
-1141
|
|
||
| export type EventAPIResponse = APIResponse & { | ||
| event: Event; | ||
| }; | ||
|
|
||
| export type PartializeKeys<T, K extends keyof T> = Partial<Pick<T, K>> & Omit<T, K>; | ||
|
|
||
| type ErrorResponseDetails = { | ||
| code: number; | ||
| messages: string[]; | ||
| }; | ||
|
|
||
| export type APIErrorResponse = { | ||
| duration: string; | ||
| message: string; | ||
| more_info: string; | ||
| StatusCode: number; | ||
| code?: number; | ||
| details?: ErrorResponseDetails; | ||
| }; | ||
|
|
||
| export type DraftMessagePayload = PartializeKeys< | ||
| Omit<DraftMessage, 'mentioned_groups'>, | ||
| 'id' | ||
| > & { | ||
| user_id?: string; | ||
| }; | ||
|
|
||
| export type QueryRemindersOptions = Pager & { | ||
| filter?: ReminderFilters; | ||
| sort?: ReminderSort; | ||
| }; |
Contributor
Author
There was a problem hiding this comment.
Replaced all of these with generated equivalents.
arnautov-anton
marked this pull request as ready for review
August 11, 2026 16:34
arnautov-anton
requested review from
MartinCupela,
isekovanic,
oliverlaz,
santhoshvai,
szuperaz and
vishalnarkhede
as code owners
August 11, 2026 16:34
oliverlaz
approved these changes
Aug 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.