Fix peer connection previous-connect analytics scope

[rahul-lohra]

Goal

Closes #AND-1368

Ensure wasPreviouslyConnected is reported only for the relevant peer connection role within the current call analytics lifecycle, instead of leaking cached state from previous calls.

Implementation

Moved peer connection “ever connected” tracking out of the client-level reporter state and into PeerConnectionAnalyticsStateHolder, so the value is scoped to peer connection analytics for the current call. PeerConnectionAnalytics now updates publisher/subscriber connected state when a CONNECTED event is observed and passes the role-specific wasPrevConnected value into ClientEventReporter.

🎨 UI Changes

None

Testing

• first connection attempts report wasPrevConnected = false
• reconnects after a successful connection report wasPrevConnected = true
• publisher and subscriber previous-connect state are tracked independently
• reporter tests use the explicit wasPrevConnected input instead of relying on cached client-level state
• Verify manually in backend logs

Summary by CodeRabbit

• Analytics

  • Improved peer-connection analytics to accurately identify whether publisher and subscriber connections have previously connected.
  • Reconnection events now report the correct prior-connection status for clearer connection lifecycle insights.

• Tests

  • Added coverage for initial connections, failures, reconnects, and publisher/subscriber-specific connection states.

[github-actions]

PR checklist ✅

All required conditions are satisfied:

• Title length is OK (or ignored by label).
• At least one pr: label exists.
• Sections ### Goal, ### Implementation, and ### Testing are filled, or the PR is bot-authored.
• An issue is linked (Linear ticket or GitHub issue), or the PR is bot-authored.

🎉 Great job! This PR is ready for review.

[coderabbitai]

Walkthrough

Peer connection analytics now tracks publisher and subscriber connection history separately. The role-specific state is passed to event reporting, which no longer stores its own connection-history map. Tests cover initial connections, failures, connected states, and publisher reconnects.

Changes

Peer connection history tracking

Layer / File(s)	Summary
Track role-specific connection history stream-video-android-core/src/main/kotlin/io/getstream/video/android/core/analytics/call/observer/PeerConnectionAnalytics.kt, stream-video-android-core/src/main/kotlin/io/getstream/video/android/core/analytics/call/observer/PeerConnectionAnalyticsStateHolder.kt	The state holder stores separate publisher and subscriber connection flags. PeerConnectionAnalytics updates and reads the flag for the current role.
Pass previous connection state to reporting stream-video-android-core/src/main/kotlin/io/getstream/video/android/core/analytics/reporting/ClientEventReporter.kt	ClientEventReporter receives wasPrevConnected from the observer and removes its local peer connection history tracking.
Validate initial and reconnect events stream-video-android-core/src/test/kotlin/io/getstream/video/android/core/analytics/call/observer/PeerConnectionAnalyticsTest.kt, stream-video-android-core/src/test/kotlin/io/getstream/video/android/core/analytics/reporting/ClientEventReporterTest.kt	Tests verify role-specific values for initial, failed, connected, and reconnecting states.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Sequence Diagram(s)

sequenceDiagram
  participant PeerConnectionAnalytics
  participant StateHolder
  participant ClientEventReporter
  PeerConnectionAnalytics->>StateHolder: update role when connection reaches CONNECTED
  PeerConnectionAnalytics->>StateHolder: read role-specific ever-connected state
  PeerConnectionAnalytics->>ClientEventReporter: report state with wasPrevConnected
  ClientEventReporter->>ClientEventReporter: handle connecting state

Loading

Suggested reviewers: aleksandar-apostolov

Poem

A rabbit tracks each stream with care,
Publisher, subscriber, flags laid bare.
First hops say false, reconnects say true,
Reports carry the state they knew.
Analytics burrows cleanly through!

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Title check	✅ Passed	The title clearly summarizes the fix to peer connection previous-connect analytics scope.
Description check	✅ Passed	The description covers the goal, implementation, testing, and absence of UI changes, but omits checklist sections and the GIF.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch improvement/rahullohra/correct-pc-connected-analytics

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[github-actions]

SDK Size Comparison 📏

SDK	Before	After	Difference	Status
stream-video-android-core	12.29 MB	12.29 MB	0.00 MB	🟢
stream-video-android-ui-xml	5.70 MB	5.70 MB	0.00 MB	🟢
stream-video-android-ui-compose	6.19 MB	6.19 MB	0.00 MB	🟢

[aleksandar-apostolov]

LGTM on the fix — clean re-scope of wasPreviouslyConnected into the per-call state holder. Please add a test asserting a new call starts wasPrevConnected = false after a prior call connected — that's the actual AND-1368 regression and it's currently uncovered.

[rahul-lohra]

Please add a test asserting a new call starts wasPrevConnected = false after a prior call connected — that's the actual AND-1368 regression and it's currently uncovered.

Added 2 tests to cover this case

1. a new call starts with wasPrevConnected set to false
2. an existing call whose Publisher was previously connected sends wasPrevConnected as true

[sonarqubecloud]

Quality Gate failed

Failed conditions
B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE