Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion build.gradle.kts
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
apply(from = "${rootDir}/scripts/open-api-code-gen.gradle.kts")

buildscript {
Expand Down Expand Up @@ -51,7 +51,7 @@
"stream-video-android-core",
"stream-video-android-ui-compose",
)
sonarCoverageExclusions = listOf(
sonarExclusions = listOf(
"**/*.mp3",
"**/*.webp",
"**/generated/**",
Expand Down
2 changes: 1 addition & 1 deletion gradle/libs.versions.toml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ allureKotlin = "2.4.0"
androidGradlePlugin = "8.5.2"
cameraCamera2 = "1.3.4"
spotless = "6.21.0"
streamConventions = "0.13.1"
streamConventions = "0.14.0"
kotlin = "1.9.25"
ksp = "1.9.25-1.0.20"
kotlinSerialization = "1.6.3"
Expand Down

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-recorded, not a regression from this bump.

The light avatar placeholder in the old image is the stream_video_call_sample vector, drawn by ParticipantVideoRenderer's LocalInspectionMode branch. The new image is DefaultMediaTrackFallbackContent: the baseSheetTertiary background plus a CircularProgressIndicator frozen at animation frame 0, which is the faint speck in the centre.

Cause is #1721, which made CallLobby pass fallbackContent = {} and overlay the loading content while !isVideoRendered. Under Paparazzi no frame ever renders, so onRendered never fires and the spinner permanently covers the placeholder. The old image was last recorded in #1534, well before that.

It surfaced here because conventions 0.14.0 makes the Paparazzi plugin check lazy, so verifyPaparazziDebug is finally wired into :testCoverage (previously hasPlugin ran before the module applied the plugin, so it was always false and verification was silently skipped). Re-recording on 0.13.1 yields a byte-identical image, so the drift predates this PR.

Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading