fix(verify): stop comparing PassMark's two scales - #58
Merged
Conversation
`passmark_multi_ge_single` asserted cpu_mark >= passmark_single, but CPU Mark and Single Thread Rating are separately normalised PassMark scales — their magnitudes are not comparable, so the check read a scale difference as a defect. Of 866 CPU records holding both figures, 123 fail. All 51 single-core parts fail, and failure tracks absolute weakness rather than parallelism: failing CPU Mark median 641 against 19,657 for passing, with near-ties at the boundary (Core 2 Duo E8600, 1378 vs 1388). The check only ever held because modern CPU Marks are large. Cinebench and Geekbench keep their multi >= single checks: those report both figures on one scale, so a violation there is a real defect. Refs #1
This was referenced Aug 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
passmark_multi_ge_singleassertspassmark_cpu_mark >= passmark_single. Those are two separately normalised PassMark scales — CPU Mark and Single Thread Rating — so their magnitudes are not comparable, and the check reads a scale difference as a defect.Measured over every CPU record holding both figures (866):
Examples, all with a Wikipedia source and no data problem:
athlon-64-3000(mark 342 / single 623),athlon-xp-1800(195 / 301),sempron-3000(299 / 530).Change
Drop the PassMark comparison.
cb23_multi_ge_singleandgb_multi_ge_singlestay — Cinebench and Geekbench report both figures on one scale, so multi ≥ single is a real expectation there, and a violation is a genuine defect.Two regression tests: a single-core PassMark pair no longer emits the signal, and a Cinebench multi < single still fails.
tests/verifyis 58 passed.Effect
57 near-miss CPU records carry this flag (near-miss = T1/T2 host, score 65–74, where
consistencyaverages 24.1/35). Removing a false failure returns those points; how many cross the green threshold of 75 will show in the next verify run rather than being predicted here.Refs #1